Fixing PR16687 to work for chassis and non-chassis#17169
Merged
arlakshm merged 1 commit intosonic-net:masterfrom Feb 26, 2025
Merged
Fixing PR16687 to work for chassis and non-chassis#17169arlakshm merged 1 commit intosonic-net:masterfrom
PR16687 to work for chassis and non-chassis#17169arlakshm merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@raaghavendrakra-arista could you take a look at this change as well. |
Javier-Tan
approved these changes
Feb 26, 2025
Contributor
There was a problem hiding this comment.
This LGTM, thanks @arista-nwolfe
@arlakshm for vis
arlakshm
approved these changes
Feb 26, 2025
arlakshm
added
Request for msft-202405 Branch
Approved for msft-202405 Branch
and removed
Request for 202405 branch
labels
Merged
11 tasks
Collaborator
|
Cherry-pick PR to msft-202405: Azure/sonic-mgmt.msft#118 |
mssonicbld
added
Included in msft-202405 Branch
and removed
Created PR to msft-202405 Branch
labels
nissampa
pushed a commit
to nissampa/sonic-mgmt_dpu_test
that referenced
this pull request
Mar 4, 2025
sonic-net#16687 recently merged to fix an issue on non-chassis systems but it broke chassis systems as described in sonic-net#17131 This change will solve the issue originally targeted by sonic-net#16687 Where 'Ethernet112|6' when split with delimiter "|" the string in 1st index "6" is a substring of "Ethernet68" By using val == interface it no longer matters if the buffer queue matches up a substring of the interface. Summary: Fixes sonic-net#17131
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Mar 15, 2025
sonic-net#16687 recently merged to fix an issue on non-chassis systems but it broke chassis systems as described in sonic-net#17131 This change will solve the issue originally targeted by sonic-net#16687 Where 'Ethernet112|6' when split with delimiter "|" the string in 1st index "6" is a substring of "Ethernet68" By using val == interface it no longer matters if the buffer queue matches up a substring of the interface. Summary: Fixes sonic-net#17131
Merged
11 tasks
Collaborator
|
Cherry-pick PR to msft-202503: Azure/sonic-mgmt.msft#214 |
mssonicbld
added
Included in msft-202503 Branch
and removed
Created PR to msft-202503 Branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#16687 recently merged to fix an issue on non-chassis systems but it broke chassis systems as described in #17131
This change will solve the issue originally targeted by #16687
Where 'Ethernet112|6' when split with delimiter "|" the string in 1st index "6" is a substring of "Ethernet68"
By using
val == interfaceit no longer matters if the buffer queue matches up a substring of the interface.Summary:
Fixes #17131
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation