Prting 16315 to 202411: qos-sai:dwrr:cisco-8000:Handle non-multiasic part as well for the dshell-script change.#17158
Merged
kevinskwang merged 3 commits intosonic-net:202411from Feb 28, 2025
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rraghav-cisco
changed the title
Contributor
Author
|
@kevinwangsk :I am not clear on the failure of the azp pipeline, can you pls help understand it ? or resubmit it? |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@rraghav-cisco should the target branch be master? |
Contributor
Author
@kevinskwang , the master PR:#16315 is already merged. This PR is for 202411. |
Contributor
|
LGTM |
kevinskwang
approved these changes
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # 16314
Type of change
Back port request
Approach
What is the motivation for this PR?
The recent commit for dwrr works for multi-asic only. This PR handles the single asic platforms.
How did you do it?
Making sure to use the correct container to use for single asic tests.
How did you verify/test it?
Not done yet. @kevinskwang , @yejianquan : Can you pls try this out ? I will try it when I get the testbed access.
Any platform specific information?
For cisco-8000 only.