[conn_graph_facts] Fix single inventory parsing error#1714
Merged
lguohan merged 1 commit intosonic-net:masterfrom May 30, 2020
Merged
[conn_graph_facts] Fix single inventory parsing error#1714lguohan merged 1 commit intosonic-net:masterfrom
lguohan merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Neetha John <nejo@microsoft.com>
tahmed-dev
approved these changes
May 29, 2020
| inv_files = [] | ||
| if isinstance(inv_opt, str): | ||
| inv_files = (duthost.host.options['inventory']) # Make it iterable for later use | ||
| inv_files = [duthost.host.options['inventory']] # Make it iterable for later use |
Contributor
There was a problem hiding this comment.
is this a comma separated list? Looks like this line is broken too
Contributor
Author
There was a problem hiding this comment.
It is a comma separated list. refer #1645. @tahmed-dev , can you fix that line as a separate PR. Not sure if there are other places as well
yxieca
approved these changes
May 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Neetha John nejo@microsoft.com
Description of PR
Fixed the issue where parsing wasn't correct while specifying single inventory file
Type of change
How did you verify/test it?
Verified that the inv name is extracted properly