[vm_set] fix ansible condition in vm_set role#1707
Merged
lguohan merged 1 commit intosonic-net:masterfrom May 28, 2020
Merged
Conversation
VM_num > 0 is evaluated to True if passed '-e VM_num="0"', cast it to int explicitely to fix the issue. Signed-off-by: Stepan Blyschak <[email protected]>
neethajohn
approved these changes
May 28, 2020
nazariig
approved these changes
May 29, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
d2baedb Remove exec from platform_reboot_plugin call to handle any hang issue. (sonic-net#1879) c54da70 [fstrim] limit smartctl execution time to 30 seconds (sonic-net#1850) cccf845 [multi-asic][cli][chassis-db] Avoid connecting to chassis db for cli commands executed from linecard (sonic-net#1707)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VM_num > 0 is evaluated to True if passed '-e VM_num="0"', cast it to
int explicitely to fix the issue.
Signed-off-by: Stepan Blyschak [email protected]
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation