Skip to content

[ZMQ] Ignore loganalyzer during ZMQ test #17018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qiluo-msft merged 5 commits into from
Feb 24, 2025
Merged

[ZMQ] Ignore loganalyzer during ZMQ test #17018

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dff48c6
Update tacacs_helper.py
liuh-80 Feb 14, 2025
76530a4
Merge branch 'sonic-net:master' into master
liuh-80 Feb 17, 2025
fefa710
Update tacacs_helper.py
liuh-80 Feb 17, 2025
346c787
Merge branch 'sonic-net:master' into master
liuh-80 Feb 19, 2025
12d348e
Update test_gnmi_zmq.py
liuh-80 Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/zmq/test_gnmi_zmq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@


pytestmark = [
pytest.mark.disable_loganalyzer,
Copy link
Copy Markdown
Collaborator

@Blueve Blueve Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arista has fixed this error log in newest release.

Do we have clue on why this test could trigger errors on other platforms?
We usually prefer to fix the error log or suppress the specific error log pattern in log analyzer instead of disabling it.
But it would make sense to disable it if the test itself could trigger error logs by nature (such as restart some critical services).

Copy link
Copy Markdown
Contributor Author

@liuh-80 liuh-80 Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test will reload config during test, which will restart all service. I think this is the reason why the error been triggered.
There are 2 kinds of error break this test, so if we don't disable log analyzer there may similar issue break this test again.

Copy link
Copy Markdown
Contributor

@yaqiangz yaqiangz Feb 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion, if error log is generated by config reload for known reason, then we could disable loganalyzer when reloading:

    loganalyzer[duthost.hostname].add_start_ignore_mark()
    config_reload()
    loganalyzer[duthost.hostname].add_end_ignore_mark()

Copy link
Copy Markdown
Contributor Author

@liuh-80 liuh-80 Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not work, because many service not fully start after config_reload command finish, it will take some time, on some slow planform for example Mellanox 2700, it will take few minutes.

pytest.mark.topology('any')
]

Expand Down
Loading