Skip test_syslog_source_ip to avoid testbed unreachable issue#17016
Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom Feb 19, 2025
Merged
Skip test_syslog_source_ip to avoid testbed unreachable issue#17016bingwang-ms merged 1 commit intosonic-net:masterfrom
bingwang-ms merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Feb 19, 2025
Collaborator
|
Cherry-pick PR to 202411: #17017 |
11 tasks
bingwang-ms
added a commit
that referenced
this pull request
Feb 19, 2025
Co-authored-by: bingwang-ms <[email protected]>
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Mar 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
PR #16998 was raised to skip the test on all platform because some testbeds were unreachable after running this test module
test_syslog_source_ip.However, test case
test_syslog_config_work_after_rebootis still running because the the longest path matching policy.This PR addressed the issue by removing the condition for
syslog/test_syslog_source_ip.py::TestSSIP::test_syslog_config_work_after_reboot, and adding the github issue to conditionsyslog/test_syslog_source_ip.py::TestSSIP::test_syslog_protocol_filter_severity.Type of change
Back port request
Approach
What is the motivation for this PR?
This PR is to skip the test case
test_syslog_source_ipto avoid testbed unreachable issue.How did you do it?
syslog/test_syslog_source_ip.py::TestSSIP::test_syslog_config_work_after_rebootsyslog/test_syslog_source_ip.py::TestSSIP::test_syslog_protocol_filter_severity.How did you verify/test it?
Verified on a pyhsical testbed
Any platform specific information?
No.
Supported testbed topology if it's a new test case?
Not a new test.
Documentation