Skip to content

Skip test_syslog_source_ip to avoid testbed unreachable issue#17016

Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom
bingwang-ms:skip_syslog_sip_test_2
Feb 19, 2025
Merged

Skip test_syslog_source_ip to avoid testbed unreachable issue#17016
bingwang-ms merged 1 commit intosonic-net:masterfrom
bingwang-ms:skip_syslog_sip_test_2

Conversation

@bingwang-ms
Copy link
Collaborator

Description of PR

Summary:
Fixes # (issue)
PR #16998 was raised to skip the test on all platform because some testbeds were unreachable after running this test module test_syslog_source_ip.

However, test case test_syslog_config_work_after_reboot is still running because the the longest path matching policy.
This PR addressed the issue by removing the condition for syslog/test_syslog_source_ip.py::TestSSIP::test_syslog_config_work_after_reboot, and adding the github issue to condition syslog/test_syslog_source_ip.py::TestSSIP::test_syslog_protocol_filter_severity.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

This PR is to skip the test case test_syslog_source_ip to avoid testbed unreachable issue.

How did you do it?

  1. Remove the condition for syslog/test_syslog_source_ip.py::TestSSIP::test_syslog_config_work_after_reboot
  2. Add the github issue to condition syslog/test_syslog_source_ip.py::TestSSIP::test_syslog_protocol_filter_severity.

How did you verify/test it?

Verified on a pyhsical testbed

collected 15 items                                                                                                                                                                                                            

syslog/test_syslog_source_ip.py::TestSSIP::test_basic_syslog_config[str-msn2700-22-None-vrf_unset_source_unset_port_None] SKIPPED (Vs setup doesn't work when creating mgmt vrf)                                        [  6%]
syslog/test_syslog_source_ip.py::TestSSIP::test_basic_syslog_config[str-msn2700-22-None-vrf_unset_source_unset_port_600] SKIPPED (Vs setup doesn't work when creating mgmt vrf)                                         [ 13%]
syslog/test_syslog_source_ip.py::TestSSIP::test_basic_syslog_config[str-msn2700-22-None-vrf_unset_source_set_port_None] SKIPPED (Vs setup doesn't work when creating mgmt vrf)                                          [ 20%]
syslog/test_syslog_source_ip.py::TestSSIP::test_basic_syslog_config[str-msn2700-22-None-vrf_unset_source_set_port_650] SKIPPED (Vs setup doesn't work when creating mgmt vrf)                                           [ 26%]
syslog/test_syslog_source_ip.py::TestSSIP::test_basic_syslog_config[str-msn2700-22-None-vrf_set_source_unset_None] SKIPPED (Vs setup doesn't work when creating mgmt vrf)                                               [ 33%]
syslog/test_syslog_source_ip.py::TestSSIP::test_basic_syslog_config[str-msn2700-22-None-vrf_set_source_unset_700] SKIPPED (Vs setup doesn't work when creating mgmt vrf)                                                [ 40%]
syslog/test_syslog_source_ip.py::TestSSIP::test_basic_syslog_config[str-msn2700-22-None-vrf_set_source_set_None] SKIPPED (Vs setup doesn't work when creating mgmt vrf)                                                 [ 46%]
syslog/test_syslog_source_ip.py::TestSSIP::test_basic_syslog_config[str-msn2700-22-None-vrf_set_source_set_800] SKIPPED (Vs setup doesn't work when creating mgmt vrf)                                                  [ 53%]
syslog/test_syslog_source_ip.py::TestSSIP::test_config_syslog_non_existing_ip[str-msn2700-22-None-no_on_any_vrf] SKIPPED (Vs setup doesn't work when creating mgmt vrf)                                                 [ 60%]
syslog/test_syslog_source_ip.py::TestSSIP::test_config_syslog_non_existing_ip[str-msn2700-22-None-only_on_other_vrf] SKIPPED (Vs setup doesn't work when creating mgmt vrf)                                             [ 66%]
syslog/test_syslog_source_ip.py::TestSSIP::test_config_syslog_with_non_existing_vrf[str-msn2700-22-None] SKIPPED (Vs setup doesn't work when creating mgmt vrf)                                                         [ 73%]
syslog/test_syslog_source_ip.py::TestSSIP::test_syslog_config_work_after_reboot[str-msn2700-22-None] SKIPPED (Vs setup doesn't work when creating mgmt vrf)                                                             [ 80%]
syslog/test_syslog_source_ip.py::TestSSIP::test_remove_vrf_exist_syslog_config[str-msn2700-22-None-Vrf-data] SKIPPED (Vs setup doesn't work when creating mgmt vrf)                                                     [ 86%]
syslog/test_syslog_source_ip.py::TestSSIP::test_remove_vrf_exist_syslog_config[str-msn2700-22-None-mgmt] SKIPPED (Vs setup doesn't work when creating mgmt vrf)                                                         [ 93%]
syslog/test_syslog_source_ip.py::TestSSIP::test_syslog_protocol_filter_severity[str-msn2700-22-None] SKIPPED (Testcase consistent failed, raised issue to track / Vs setup doesn't work when creating mgmt vrf)         [100%]

Any platform specific information?

No.

Supported testbed topology if it's a new test case?

Not a new test.

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms bingwang-ms merged commit 8ae10a0 into sonic-net:master Feb 19, 2025
9 of 18 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Feb 19, 2025
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202411: #17017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants