[action] [PR:16687] Fixed logic to delete the interface from BUFFER_QUEUE#16996
Merged
mssonicbld merged 1 commit intosonic-net:202411from Feb 17, 2025
Merged
Conversation
Description of PR The interface from where the queuestats fetched was different from the interface that was deleted from the BUFFER_QUEUE. Github issue: aristanetworks/sonic-qual.msft#371 This issue is seen after PR: sonic-net#15688 The issue was that XML dump is below for context buffer_queue_to_del = 'Ethernet112|6' buffer_queues = ['Ethernet112|0-1', 'Ethernet112|2-4', 'Ethernet112|5', 'Ethernet112|6', 'Ethernet112|7', 'Ethernet116|0-1', ...] buffer_queues_removed = 1 interface = 'Ethernet68' When the string 'Ethernet112|6' when split with delimiter "|" the string in 1st index "6" is a substring of "Ethernet68" and it picked as a candidate to delete it from BQ, which is wrong. Summary: Fixes # aristanetworks/sonic-qual.msft#371
Collaborator
Author
|
/azp run |
11 tasks
Collaborator
Author
|
Original PR: #16687 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
The interface from where the queuestats fetched was different from the interface that was deleted from the BUFFER_QUEUE.
Github issue: https://github.com/aristanetworks/sonic-qual.msft/issues/371
This issue is seen after PR: #15688
The issue was that
XML dump is below for context
When the string 'Ethernet112|6' when split with delimiter "|" the string in 1st index "6" is a substring of "Ethernet68" and it picked as a candidate to delete it from BQ, which is wrong.
Summary:
Fixes # https://github.com/aristanetworks/sonic-qual.msft/issues/371
Type of change
Back port request
Approach
What is the motivation for this PR?
to address the issue https://github.com/aristanetworks/sonic-qual.msft/issues/371
How did you do it?
Through code-walk and xml dump from TC run.
How did you verify/test it?
I re-ran the test to make sure the interface delete logic is working fine
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation