Skip to content

Fix to correct the parameters passed to this API get_macsec_counters #16978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
judyjoseph merged 2 commits into from
Feb 17, 2025
Merged

Fix to correct the parameters passed to this API get_macsec_counters #16978

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b55d45e
Fix to correct the parameters passed to this API get_macsec_counters
judyjoseph Feb 14, 2025
aed6fb4
Remove collections.Counter as imported but unused
judyjoseph Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions tests/common/macsec/macsec_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import json
import logging
import time
from collections import defaultdict, deque, Counter
from collections import defaultdict, deque
from multiprocessing import Process

import cryptography.exceptions
Expand Down Expand Up @@ -401,10 +401,9 @@ def get_macsec_attr(host, port):
else:
peer_ssci = None

# Get the packet number
ns = host.get_namespace_from_asic_id(asic.asic_index) if host.is_multi_asic else ''
counters = Counter(get_macsec_counters(asic, ns, macsec_ingress_sa_name))
pn = counters['SAI_MACSEC_SA_ATTR_CURRENT_XPN']
# Get the packet number from ingress SA
egress_dict, ingress_dict = get_macsec_counters(host, port)
pn = ingress_dict['SAI_MACSEC_SA_ATTR_CURRENT_XPN']

return encrypt, send_sci, xpn_en, sci, an, sak, ssci, salt, int(peer_sci, 16), int(peer_an), peer_ssci, pn

Expand Down
Loading