Add safe_reload for config_reload in test_syslog_srouce_ip#16969
Merged
StormLiangMS merged 1 commit intosonic-net:masterfrom Feb 17, 2025
Merged
Add safe_reload for config_reload in test_syslog_srouce_ip#16969StormLiangMS merged 1 commit intosonic-net:masterfrom
StormLiangMS merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Zhaohui Sun <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@JibinBao could you please help review? |
JibinBao
approved these changes
Feb 14, 2025
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Feb 17, 2025
…#16969) What is the motivation for this PR? Without safe_reload, it's not enough time to wait system healthy. safe_reload will check critical services after reload. How did you do it? Add safe_reload=True, for config_reload How did you verify/test it? Run test_syslog_source_ip on testbed.
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Feb 17, 2025
…#16969) What is the motivation for this PR? Without safe_reload, it's not enough time to wait system healthy. safe_reload will check critical services after reload. How did you do it? Add safe_reload=True, for config_reload How did you verify/test it? Run test_syslog_source_ip on testbed.
Collaborator
|
Cherry-pick PR to 202411: #16993 |
Collaborator
|
Cherry-pick PR to 202405: #16994 |
This was referenced Feb 17, 2025
mssonicbld
pushed a commit
that referenced
this pull request
Feb 17, 2025
What is the motivation for this PR? Without safe_reload, it's not enough time to wait system healthy. safe_reload will check critical services after reload. How did you do it? Add safe_reload=True, for config_reload How did you verify/test it? Run test_syslog_source_ip on testbed.
mssonicbld
added
Included in 202411 branch
and removed
Created PR to 202411 branch
labels
mssonicbld
pushed a commit
that referenced
this pull request
Feb 18, 2025
What is the motivation for this PR? Without safe_reload, it's not enough time to wait system healthy. safe_reload will check critical services after reload. How did you do it? Add safe_reload=True, for config_reload How did you verify/test it? Run test_syslog_source_ip on testbed.
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
wangxin
pushed a commit
to wangxin/sonic-mgmt
that referenced
this pull request
Feb 21, 2025
…#16969) What is the motivation for this PR? Without safe_reload, it's not enough time to wait system healthy. safe_reload will check critical services after reload. How did you do it? Add safe_reload=True, for config_reload How did you verify/test it? Run test_syslog_source_ip on testbed.
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Mar 15, 2025
…#16969) What is the motivation for this PR? Without safe_reload, it's not enough time to wait system healthy. safe_reload will check critical services after reload. How did you do it? Add safe_reload=True, for config_reload How did you verify/test it? Run test_syslog_source_ip on testbed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Without safe_reload, it's not enough time to wait system healthy. safe_reload will check critical services after reload.
How did you do it?
Add safe_reload=True, for config_reload
How did you verify/test it?
Run test_syslog_source_ip on testbed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation