Skip to content

[action] [PR:16876] feat: add fixture for disabling route check#16924

Merged
mssonicbld merged 1 commit intosonic-net:202411from
mssonicbld:cherry/202411/16876
Feb 13, 2025
Merged

[action] [PR:16876] feat: add fixture for disabling route check#16924
mssonicbld merged 1 commit intosonic-net:202411from
mssonicbld:cherry/202411/16876

Conversation

@mssonicbld
Copy link
Collaborator

Description of PR

Add a module-level fixture for temporarily disabling route check for a test module

Summary:
Fixes # (issue) Microsoft ADO 31326413

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
  • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

In our recent Cisco T2 Nightly run, we observed that we would get the following error syslog during some test modules:

E Failed: Processes "['analyze_logs--<MultiAsicSonicHost dut-lc1-1>']" failed with exit code "1"
E Exception:
E match: 1
E expected_match: 0
E expected_missing_match: 0
E 
E Match Messages:
E 2025 Feb 3 03:03:29.550827 svcstr2-8800-lc1-1 ERR monit[914]: 'routeCheck' status failed (255) -- Failure results: {{#012 "asic1": {#012 "Unaccounted_ROUTE_ENTRY_TABLE_entries": [#012 "100.1.0.22/32",#012

After discussion, we decided to add a fixture so users can disable route check for a test module if they think that test tends to have such error syslog.

How did you do it?

How did you verify/test it?

I ran the updated code and can confirm it's working well.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Description of PR
Add a module-level fixture for temporarily disabling route check for a test module

Summary:
Fixes # (issue) Microsoft ADO 31326413

Approach
What is the motivation for this PR?
In our recent Cisco T2 Nightly run, we observed that we would get the following error syslog during some test modules:

E               Failed: Processes "['analyze_logs--<MultiAsicSonicHost dut-lc1-1>']" failed with exit code "1"
E               Exception:
E               match: 1
E               expected_match: 0
E               expected_missing_match: 0
E               
E               Match Messages:
E               2025 Feb  3 03:03:29.550827 svcstr2-8800-lc1-1 ERR monit[914]: 'routeCheck' status failed (255) -- Failure results: {{sonic-net#12    "asic1": {sonic-net#12        "Unaccounted_ROUTE_ENTRY_TABLE_entries": [sonic-net#12            "100.1.0.22/32",sonic-net#12
After discussion, we decided to add a fixture so users can disable route check for a test module if they think that test tends to have such error syslog.

How did you do it?
How did you verify/test it?
I ran the updated code and can confirm it's working well.

co-authorized by: jianquanye@microsoft.com
@mssonicbld mssonicbld requested a review from prgeor as a code owner February 12, 2025 06:12
@mssonicbld
Copy link
Collaborator Author

/azp run

@mssonicbld
Copy link
Collaborator Author

Original PR: #16876

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld mssonicbld merged commit 4b5c587 into sonic-net:202411 Feb 13, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants