Skip to content

RDMA Tests Fix#16881

Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom
YatishSVC:rdma_enhancements
Feb 11, 2025
Merged

RDMA Tests Fix#16881
bingwang-ms merged 1 commit intosonic-net:masterfrom
YatishSVC:rdma_enhancements

Conversation

@YatishSVC
Copy link
Copy Markdown
Contributor

@YatishSVC YatishSVC commented Feb 10, 2025

Description of PR

Summary:
Fixes # (issue)
The test used to select supervisor sometimes which will not work in case of Nokia and Arista Chassis.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Feb 10, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Feb 10, 2025

Azure Pipelines successfully started running 1 pipeline(s).

bingwang-ms
bingwang-ms approved these changes Feb 11, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@bingwang-ms bingwang-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bingwang-ms bingwang-ms merged commit 36e23b5 into sonic-net:master Feb 11, 2025
18 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Feb 13, 2025
@YatishSVC @yatishkoul @mssonicbld
Added Change to not select sup while running rdma tests (sonic-net#16881
0a16ac1 
)

Co-authored-by: yatishkoul <[email protected]>
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Feb 13, 2025

Cherry-pick PR to 202405: #16954

@mssonicbld mssonicbld mentioned this pull request Feb 13, 2025
Merged
11 tasks
@bingwang-ms
Copy link
Copy Markdown
Collaborator

bingwang-ms commented Feb 13, 2025

@YatishSVC I closed the cherry-pick PR for 202405 branch as the PR is an enhancement. Please let me know if this is a must have change, I will redo the cherry-pick. Thanks

@arlakshm
Copy link
Copy Markdown
Contributor

arlakshm commented Feb 13, 2025

@YatishSVC I closed the cherry-pick PR for 202405 branch as the PR is an enhancement. Please let me know if this is a must have change, I will redo the cherry-pick. Thanks

@bingwang-ms these are not enhancements they are bug fixes. We will cherry-pick to the msft/202405 because this is needed for chassis

@mssonicbld mssonicbld mentioned this pull request Feb 13, 2025
Merged
11 tasks
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Feb 13, 2025

Cherry-pick PR to msft-202405: Azure/sonic-mgmt.msft#83

@bingwang-ms
Copy link
Copy Markdown
Collaborator

bingwang-ms commented Feb 13, 2025 •
edited
Loading

@YatishSVC I closed the cherry-pick PR for 202405 branch as the PR is an enhancement. Please let me know if this is a must have change, I will redo the cherry-pick. Thanks

@bingwang-ms these are not enhancements they are bug fixes. We will cherry-pick to the msft/202405 because this is needed for chassis

I see. Sorry I was confused by the PR title. Please let me know if you still need this change in 202405

@YatishSVC YatishSVC changed the title RDMA Tests Enhancements RDMA Tests Fix Feb 13, 2025
@YatishSVC
Copy link
Copy Markdown
Contributor Author

YatishSVC commented Feb 13, 2025

Hi @bingwang-ms
Sorry for the confusion,
I've changed the title of this pr.
Actually, this fix is to not select supervisor node while running the tests and it's good to have in 202405.
Please do let me know if you have any questions.

mssonicbld pushed a commit that referenced this pull request Feb 18, 2025
@YatishSVC @yatishkoul @mssonicbld
Added Change to not select sup while running rdma tests (#16881)
0a8d9ca 
Co-authored-by: yatishkoul <[email protected]>
@vmittal-msft vmittal-msft self-requested a review February 21, 2025 20:15
@vmittal-msft
Copy link
Copy Markdown
Contributor

vmittal-msft commented Feb 21, 2025

@amitpawar12 @ansrajpu-git @saksarav-nokia

nnelluri-cisco pushed a commit to nnelluri-cisco/sonic-mgmt that referenced this pull request Mar 15, 2025
@YatishSVC @yatishkoul @nnelluri-cisco
Added Change to not select sup while running rdma tests (sonic-net#16881
5e9e18f 
)

Co-authored-by: yatishkoul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arlakshm arlakshm arlakshm approved these changes

@bingwang-ms bingwang-ms bingwang-ms approved these changes

@sdszhang sdszhang Awaiting requested review from sdszhang

@vmittal-msft vmittal-msft Awaiting requested review from vmittal-msft

Assignees

@YatishSVC YatishSVC

Labels

Approved for msft-202405 Branch Included in msft-202405 Branch Included in 202405 branch Request for msft-202405 Branch Request for 202411 branch

Projects

SONiC Chassis
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@YatishSVC @mssonicbld @bingwang-ms @arlakshm @vmittal-msft @yatishkoul