Skip to content

[sad_path] Fix show ip bgp neighbors cmd#1680

Merged
yxieca merged 1 commit intosonic-net:masterfrom
msosyak:fix_bgp_command
May 31, 2020
Merged

[sad_path] Fix show ip bgp neighbors cmd#1680
yxieca merged 1 commit intosonic-net:masterfrom
msosyak:fix_bgp_command

Conversation

@msosyak
Copy link
Contributor

@msosyak msosyak commented May 18, 2020

Description of PR

It looks like some changes in CLI brokes warm-reboot-sad tests.
Summary: Fix command line to retrieve the BGP neighbor state.
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

How did you do it?

Correct CLI command called from tests

How did you verify/test it?

Run warm-reboot-sad test

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

Documentation

sonic-mgmt based on f11d076

@msosyak
Copy link
Contributor Author

msosyak commented May 25, 2020

@tahmed-dev @yxieca Please review

@wangxin
Copy link
Collaborator

wangxin commented May 29, 2020

I don't quite understand since even command show ip bgp nei works on my side. Of course show ip bgp neighbor works too.

Copy link
Collaborator

@yxieca yxieca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad that the cli command abbreviation is broken. We need to fix that. But let's get test running first

@yxieca yxieca merged commit 0ec2bb9 into sonic-net:master May 31, 2020
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
utilities:
* 83f068b 2021-03-22 | Handling error scenario of adding port to Vlan which is part of LAG (sonic-net#1516) (HEAD -> 202012) [Sudharsan Dhamal Gopalarathnam]
* 470e8ce 2021-03-24 | Enable PFCWD only on ports where PFC is enabled (sonic-net#1508) [Andriy Yurkiv]
* 09ef2e0 2021-03-22 | [show][config] add support for setting and displaying switching modes on Y cable (sonic-net#1501) [vdahiya12]
* 0d17d37 2021-03-24 | Warmboot script improvements - timeout exec, disable swss autorestart, remove trap (sonic-net#1495) [Vaibhav Hemant Dixit]
* 2718cd8 2021-03-24 | [show] Fix int status of LAGs, configured as Vlan members (sonic-net#1478) [maksymbelei95]
* cc168fb 2021-03-22 | Fix bug: show vlan config for vlan with no members (sonic-net#1503) [allas-nvidia]

swss:
* 5d8d1fb 2021-03-26 | Revert "Revert "[buffermgr] Support maximum port headroom checking (sonic-net#1607)" (sonic-net#1675)" (sonic-net#1682) (HEAD -> 202012) [Prince Sunny]
* f8df1f8 2021-03-26 | [Dynamic Buffer Calc] Enhance the field checking in table handling (sonic-net#1680) [Stephen Sun]
* 6328c9f 2021-03-22 | [MuxOrch] FDB ageout safety check (sonic-net#1674) [Prince Sunny]
* e1d733e 2021-03-21 | reduce severity of log to info in case of flush on non-existing member (sonic-net#1669) [allas-nvidia]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants