[t0 t1 test merge] merge PFC multidut #16783
Merged
yejianquan merged 1 commit intosonic-net:masterfrom Feb 27, 2025
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
auspham
force-pushed
the
austinpham/31217322-merge-multidut-pfc
branch
from
ad5faff to
25cf76b
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
auspham
force-pushed
the
austinpham/31217322-merge-multidut-pfc
branch
from
25cf76b to
fe4f0e6
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
auspham
force-pushed
the
austinpham/31217322-merge-multidut-pfc
branch
from
fe4f0e6 to
4d16264
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
auspham
force-pushed
the
austinpham/31217322-merge-multidut-pfc
branch
from
4d16264 to
17e34b5
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
auspham
commented
Feb 5, 2025
| test_traffic_pause, | ||
| snappi_extra_params=None): | ||
| duthost=None, | ||
| dut_port=None, |
Contributor
Author
There was a problem hiding this comment.
please note new changes for t0 t2 compatibility
| egress_duthost = rx_port['duthost'] | ||
|
|
||
| tx_port = snappi_extra_params.multi_dut_params.multi_dut_ports[1] | ||
| ingress_duthost = tx_port['duthost'] |
auspham
commented
Feb 5, 2025
| flow_metrics=in_flight_flow_metrics, | ||
| snappi_extra_params=snappi_extra_params) | ||
| snappi_extra_params=snappi_extra_params, | ||
| asic_value=tx_port.get('asic_value')) |
Contributor
Author
There was a problem hiding this comment.
also here change to tx_port.get(..)
auspham
changed the title
sdszhang
reviewed
Feb 8, 2025
auspham
force-pushed
the
austinpham/31217322-merge-multidut-pfc
branch
from
17e34b5 to
41719d0
Compare
Collaborator
|
/azp run |
|
Pull request contains merge conflicts. |
auspham
force-pushed
the
austinpham/31217322-merge-multidut-pfc
branch
from
41719d0 to
513b029
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdszhang
reviewed
Feb 9, 2025
tests/common/plugins/conditional_mark/tests_mark_conditions.yaml
Outdated
Show resolved
Hide resolved
Contributor
auspham
force-pushed
the
austinpham/31217322-merge-multidut-pfc
branch
from
2463d03 to
12c4373
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
developfast
approved these changes
Feb 24, 2025
Contributor
developfast
left a comment
developfast
left a comment
There was a problem hiding this comment.
code move from multidut directory to t0 directory - no new code added
sdszhang
approved these changes
Feb 24, 2025
Signed-off-by: Austin Pham <austinpham@microsoft.com>
auspham
force-pushed
the
austinpham/31217322-merge-multidut-pfc
branch
from
12c4373 to
1612479
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@auspham PR conflicts with 202411 branch |
This was referenced Feb 27, 2025
yejianquan
added a commit
to Azure/sonic-mgmt.msft
that referenced
this pull request
Feb 27, 2025
…2405 chore: merge multidut pfc folder (cherry-pick #16783) Description of PR Summary: Fix cherrypick sonic-net/sonic-mgmt#16783 co-authorized by: jianquanye@microsoft.com
yejianquan
added
Approved for msft-202405 Branch
Included in msft-202405 Branch
and removed
Cherry Pick Conflict_msft-202405
labels
yejianquan
pushed a commit
that referenced
this pull request
Mar 3, 2025
Description of PR Summary: fix conflict #16783 for 202411 Signed-off-by: Austin Pham <austinpham@microsoft.com>
nissampa
pushed a commit
to nissampa/sonic-mgmt_dpu_test
that referenced
this pull request
Mar 4, 2025
Description of PR Summary: merge multidut pfc folder Fixes # (issue) 31217322 As part of test merge plan, we're merging tests/snappi_tests/multidut to tests/snappi_tests for PFC folder. This PR simply moving over the same code in tests/snappi_tests/multidut/pfc to tests/snappi_tests/pfc as it and resolve a few conflicts. Need to merge sonic-net#16694 first before this Approach What is the motivation for this PR? Described above How did you do it? All the tests in tests/snappi_tests/multidut/pfc folder are ran nightly on t0 to verify the status Compare each file in tests/snappi_tests/multidut/pfc folder with tests/snappi_tests/pfc folder to find the differences Resolve the differences and modify so that it fits with t0 platform Ran regression on t0 platforms and verify if it works How did you verify/test it? We run regression on T0 platform and T2 platforms to verify if this works. Verification includes 2 main process Nightly verification trigger on before-merge branch multidut for regression Verification trigger on original tests/snappi_tests/pfc folder for baseline comparison Verification trigger on after-merge branch to compare new process. Only failures existed in baseline are acceptable. Signed-off-by: Austin Pham <austinpham@microsoft.com>
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Mar 15, 2025
Description of PR Summary: merge multidut pfc folder Fixes # (issue) 31217322 As part of test merge plan, we're merging tests/snappi_tests/multidut to tests/snappi_tests for PFC folder. This PR simply moving over the same code in tests/snappi_tests/multidut/pfc to tests/snappi_tests/pfc as it and resolve a few conflicts. Need to merge sonic-net#16694 first before this Approach What is the motivation for this PR? Described above How did you do it? All the tests in tests/snappi_tests/multidut/pfc folder are ran nightly on t0 to verify the status Compare each file in tests/snappi_tests/multidut/pfc folder with tests/snappi_tests/pfc folder to find the differences Resolve the differences and modify so that it fits with t0 platform Ran regression on t0 platforms and verify if it works How did you verify/test it? We run regression on T0 platform and T2 platforms to verify if this works. Verification includes 2 main process Nightly verification trigger on before-merge branch multidut for regression Verification trigger on original tests/snappi_tests/pfc folder for baseline comparison Verification trigger on after-merge branch to compare new process. Only failures existed in baseline are acceptable. Signed-off-by: Austin Pham <austinpham@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: merge multidut pfc folder
Fixes # (issue) 31217322
As part of test merge plan, we're merging tests/snappi_tests/multidut to tests/snappi_tests for PFC folder.
This PR simply moving over the same code in tests/snappi_tests/multidut/pfc to tests/snappi_tests/pfc as it and resolve a few conflicts.
Need to merge #16694 first before this
Type of change
Back port request
Approach
What is the motivation for this PR?
Described above
How did you do it?
How did you verify/test it?
We run regression on T0 platform and T2 platforms to verify if this works. Verification includes 2 main process
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation