fix: pfc timer accuracy timestamp regex#16757
Merged
yejianquan merged 1 commit intosonic-net:masterfrom Feb 3, 2025
Merged
Conversation
Signed-off-by: Austin Pham <austinpham@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
11 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Feb 3, 2025
Description of PR Summary: Fixes # (issue) 31202914 From sonic-net#16446 we are changing to use regex to capture the timestamp for pfc timer accuracy. However, the regex does not cover the scenario where date digit is 1. For example: 2025 Jan 5 00:53:14.103188 Approach What is the motivation for this PR? Comparing between: 2025 Jan 26 17:36:31.27789 2025 Feb 2 15:17:24.055182 We can see that we might need up to 2 spaces after month and the number of day digits can vary between 1 to 2. How did you do it? Adjust the regex so it matches for both format How did you verify/test it? image Signed-off-by: Austin Pham <austinpham@microsoft.com>
Collaborator
|
Cherry-pick PR to 202411: #16763 |
Collaborator
|
Cherry-pick PR to msft-202405: Azure/sonic-mgmt.msft#53 |
11 tasks
Collaborator
|
@lipxu please suggest whether need to go to 202405 branch |
mssonicbld
pushed a commit
that referenced
this pull request
Feb 3, 2025
Description of PR Summary: Fixes # (issue) 31202914 From #16446 we are changing to use regex to capture the timestamp for pfc timer accuracy. However, the regex does not cover the scenario where date digit is 1. For example: 2025 Jan 5 00:53:14.103188 Approach What is the motivation for this PR? Comparing between: 2025 Jan 26 17:36:31.27789 2025 Feb 2 15:17:24.055182 We can see that we might need up to 2 spaces after month and the number of day digits can vary between 1 to 2. How did you do it? Adjust the regex so it matches for both format How did you verify/test it? image Signed-off-by: Austin Pham <austinpham@microsoft.com>
mssonicbld
added
Included in 202411 branch
and removed
Created PR to 202411 branch
labels
Contributor
Thanks @yejianquan , please backport it to 202405 branch |
Contributor
|
Hi, @auspham Thanks for addressing the failure, do you think we need to modify the regex1 pattern, too? |
Contributor
Author
Yes, thanks for pointing out. |
Collaborator
@bingwang-ms FYI |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Feb 11, 2025
Description of PR Summary: Fixes # (issue) 31202914 From sonic-net#16446 we are changing to use regex to capture the timestamp for pfc timer accuracy. However, the regex does not cover the scenario where date digit is 1. For example: 2025 Jan 5 00:53:14.103188 Approach What is the motivation for this PR? Comparing between: 2025 Jan 26 17:36:31.27789 2025 Feb 2 15:17:24.055182 We can see that we might need up to 2 spaces after month and the number of day digits can vary between 1 to 2. How did you do it? Adjust the regex so it matches for both format How did you verify/test it? image Signed-off-by: Austin Pham <austinpham@microsoft.com>
Collaborator
|
Approved for 202405 as same issue is also seen there. |
Collaborator
|
Cherry-pick PR to 202405: #16890 |
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Feb 11, 2025
Description of PR Summary: Fixes # (issue) 31202914 From #16446 we are changing to use regex to capture the timestamp for pfc timer accuracy. However, the regex does not cover the scenario where date digit is 1. For example: 2025 Jan 5 00:53:14.103188 Approach What is the motivation for this PR? Comparing between: 2025 Jan 26 17:36:31.27789 2025 Feb 2 15:17:24.055182 We can see that we might need up to 2 spaces after month and the number of day digits can vary between 1 to 2. How did you do it? Adjust the regex so it matches for both format How did you verify/test it? image Signed-off-by: Austin Pham <austinpham@microsoft.com>
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
This was referenced Feb 11, 2025
Merged
11 tasks
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Mar 15, 2025
Description of PR Summary: Fixes # (issue) 31202914 From sonic-net#16446 we are changing to use regex to capture the timestamp for pfc timer accuracy. However, the regex does not cover the scenario where date digit is 1. For example: 2025 Jan 5 00:53:14.103188 Approach What is the motivation for this PR? Comparing between: 2025 Jan 26 17:36:31.27789 2025 Feb 2 15:17:24.055182 We can see that we might need up to 2 spaces after month and the number of day digits can vary between 1 to 2. How did you do it? Adjust the regex so it matches for both format How did you verify/test it? image Signed-off-by: Austin Pham <austinpham@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue) 31202914
From #16446 we are changing to use regex to capture the timestamp for pfc timer accuracy. However, the regex does not cover the scenario where date digit is 1. For example:
2025 Jan 5 00:53:14.103188Type of change
Back port request
Approach
What is the motivation for this PR?
Comparing between:
2025 Jan 26 17:36:31.277892025 Feb 2 15:17:24.055182We can see that we might need up to 2 spaces after month and the number of day digits can vary between 1 to 2.
How did you do it?
Adjust the regex so it matches for both format
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation