feat: use round() instead of ceil to fix #16080#16705
Merged
yejianquan merged 1 commit intosonic-net:masterfrom Jan 29, 2025
Merged
feat: use round() instead of ceil to fix #16080#16705yejianquan merged 1 commit intosonic-net:masterfrom
yejianquan merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@rraghav-cisco and @sdszhang for review |
auspham
force-pushed
the
austinpham/31122081-fix-16080
branch
from
cdbee7a to
e0311d3
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Austin Pham <[email protected]>
auspham
force-pushed
the
austinpham/31122081-fix-16080
branch
from
e0311d3 to
b3aff46
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rraghav-cisco
approved these changes
Jan 29, 2025
auspham
changed the title
sdszhang
approved these changes
Jan 29, 2025
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 29, 2025
Description of PR Summary: Use method round() to suit better need comparing to ceil vs int(). Fixes # (issue) sonic-net#16080 Signed-off-by: Austin Pham <[email protected]>
11 tasks
Collaborator
|
Cherry-pick PR to 202411: #16720 |
11 tasks
Collaborator
|
Cherry-pick PR to msft-202405: Azure/sonic-mgmt.msft#33 |
mssonicbld
pushed a commit
that referenced
this pull request
Jan 30, 2025
mssonicbld
added
Included in 202411 branch
and removed
Created PR to 202411 branch
labels
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Mar 15, 2025
Description of PR Summary: Use method round() to suit better need comparing to ceil vs int(). Fixes # (issue) sonic-net#16080 Signed-off-by: Austin Pham <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Use method
round()to suit better need comparing to ceil vs int().Fixes # (issue) #16080
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation