Fix the platform_info test failure because of callback loader#1667
Merged
sujinmkang merged 1 commit intosonic-net:201811from May 14, 2020
sujinmkang:platform_info
Merged
Fix the platform_info test failure because of callback loader#1667sujinmkang merged 1 commit intosonic-net:201811from sujinmkang:platform_info
sujinmkang merged 1 commit intosonic-net:201811from
sujinmkang:platform_info
Conversation
wangxin
approved these changes
May 13, 2020
Contributor
|
Do you want to PR against master, and cherry-pick to 201811? |
Contributor
|
agree with @qiluo-msft |
Contributor
Author
|
@qiluo-msft and @lguohan Since master branch supports the latest version of ansible from beginning and it only import the callback_loader from the new ansible path, I thought it will be ok to keep the change in master as is but for 201811, the ansible version changed later so I added this change to support both old and new ansible plugin version. |
Contributor
Author
|
@qiluo-msft and @lguohan ansible_host.py is removed on master with (#1658) so it's not possible to pr to master. |
qiluo-msft
approved these changes
May 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
platform_info test on 201811 branch failed with following error
Summary:
Fixes # (issue)
change to pick up the proper path for the callback_loader plugin path based on ansible version
Type of change
Approach
How did you do it?
Import the callback_loader from the right path
How did you verify/test it?
Run test_platform_info.py
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation