Skip to content

Test SRv6 dataplane uN behavior#16660

Merged
abdosi merged 15 commits intosonic-net:masterfrom
BYGX-wcr:test-srv6-traffic
Jan 31, 2025
Merged

Test SRv6 dataplane uN behavior#16660
abdosi merged 15 commits intosonic-net:masterfrom
BYGX-wcr:test-srv6-traffic

Conversation

@BYGX-wcr
Copy link
Copy Markdown
Contributor

@BYGX-wcr BYGX-wcr commented Jan 23, 2025

Description of PR

Summary: Test the basic uN forwarding and decap behavior of SRv6
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • [] Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@BYGX-wcr BYGX-wcr requested a review from abdosi January 23, 2025 23:59
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

self.connected = False
self.ptfhost = ptfhost
self._init_ptf_dataplane(ptf_ip, ptf_nn_port, device_num, ptf_port_set)
self._init_ptf_dataplane(ptf_ip, ptf_ipv6, ptf_nn_port, device_num, ptf_port_set)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need this change ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because the ptf_ipv6 attribute is currently missing in ptfadapter fixture. And in this test case, we need to use the ipv6 address of ptf container as the source ipv6 address.

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@BYGX-wcr BYGX-wcr changed the title Test srv6 basic forwarding Test SRv6 dataplane uN behavior Jan 28, 2025
time.sleep(5)

for i in range(0, 10):
injected_pkt = simple_ipv6_sr_packet(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's send packet without SRH also.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added parametrization to achieve this goal

skip:
reason: "Only target mellanox platform with 202412 image at this time"
conditions:
- "asic_type in ['mellanox'] and release in ['202412']"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add Broadcom also here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@abdosi abdosi merged commit 3eb108c into sonic-net:master Jan 31, 2025
16 checks passed
@BYGX-wcr BYGX-wcr deleted the test-srv6-traffic branch February 4, 2025 00:12
@r12f
Copy link
Copy Markdown
Collaborator

r12f commented Feb 18, 2025

hi @BYGX-wcr , any dependent PR that we need to merge before this one?

@BYGX-wcr
Copy link
Copy Markdown
Contributor Author

hi @BYGX-wcr , any dependent PR that we need to merge before this one?

To the best of my knowledge, no.

@r12f
Copy link
Copy Markdown
Collaborator

r12f commented Feb 18, 2025

hi @BYGX-wcr , any dependent PR that we need to merge before this one?

To the best of my knowledge, no.

I see. I have tried to pull some of the SRv6 changes in, but still conflicting, then this looks like a legit conflict. Do you mind helping create a manual cherry pick PR to 202412?

@BYGX-wcr
Copy link
Copy Markdown
Contributor Author

hi @BYGX-wcr , any dependent PR that we need to merge before this one?

To the best of my knowledge, no.

I see. I have tried to pull some of the SRv6 changes in, but still conflicting, then this looks like a legit conflict. Do you mind helping create a manual cherry pick PR to 202412?

Check the cherry-pick PR below:

Azure/sonic-mgmt.msft#93

The conflict happened on the conditional marker file.

@r12f
Copy link
Copy Markdown
Collaborator

r12f commented Feb 19, 2025

manual picked into 202412.

nnelluri-cisco pushed a commit to nnelluri-cisco/sonic-mgmt that referenced this pull request Mar 15, 2025
Test SRv6 dataplane uN and uN +USD behavior
nhe-NV pushed a commit to nhe-NV/sonic-mgmt that referenced this pull request May 12, 2025
Test SRv6 dataplane uN and uN +USD behavior
nhe-NV pushed a commit to nhe-NV/sonic-mgmt that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants