[Qos]Fixture update for duthost selection in test_pfc_counter.py#16654
[Qos]Fixture update for duthost selection in test_pfc_counter.py#16654rlhui merged 3 commits intosonic-net:masterfrom
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@vmittal-msft ,please review |
|
@StormLiangMS @wangxin please review for T0/T1 side. |
|
@ansrajpu-git is it possible to add some details about what failure you were seeing that prompted this change? |
|
Can you provide details on failures seen running |
|
@ansrajpu-git - please add why is this change needed in description of the PR? Thanks. |
|
@ansrajpu-git need more background info to know if this change will impact single box device? can you help to share detail |
@XuChen-MSFT , the enum_rand_one_per_hwsku_frontend_hostname will select the DUT per hwsku of the frontend node. It should work fine with the selection of dut with single box as well. |
XuChen-MSFT
left a comment
XuChen-MSFT
left a comment
There was a problem hiding this comment.
checked enum_rand_one_per_hwsku_hostname logic in pytest_generate_tests, should be compatible with single box device.
and manually run qos/test_pfc_counters.py on t1 single box device, test passed.
approved.
|
@ansrajpu-git please create a msft 202405 PR for this? thanks. |
…ic-net#16654) Test failures in test_pfc_counters.py How did you do it? Change the 'duthosts[rand_one_tgen_dut_hostname]' to 'duthosts[enum_rand_one_per_hwsku_frontend_hostname]' and. 'fanout_graph_facts' to 'enum_fanout_graph_facts'
|
…ic-net#16654) Test failures in test_pfc_counters.py How did you do it? Change the 'duthosts[rand_one_tgen_dut_hostname]' to 'duthosts[enum_rand_one_per_hwsku_frontend_hostname]' and. 'fanout_graph_facts' to 'enum_fanout_graph_facts'
7 participants
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Test failures in test_pfc_counters.py
How did you do it?
Change the 'duthosts[rand_one_tgen_dut_hostname]' to 'duthosts[enum_rand_one_per_hwsku_frontend_hostname]'
and.
'fanout_graph_facts' to 'enum_fanout_graph_facts'
How did you verify/test it?
Executed t2 test for broadcom-dnx chassis & verify the results.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation