fix UnboundLocalError in test_pfcwd_function.py#16631
Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom Jan 22, 2025
Merged
fix UnboundLocalError in test_pfcwd_function.py#16631bingwang-ms merged 1 commit intosonic-net:masterfrom
bingwang-ms merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Test result (MSFT only access): This PR fixs the syntax error only. The new code path was skipped previously on cisco platform. Will let cisco to open another PR to fix them on cisco platform. |
Contributor
Author
|
@rbpittman @bingwang-ms can you help to review? |
bingwang-ms
approved these changes
Jan 22, 2025
yejianquan
added
Approved for 202405 branch
and removed
Approved for 202405 branch
labels
10 tasks
Javier-Tan
added
Created PR to msft-202405 Branch
Included in msft-202405 Branch
and removed
Created PR to msft-202405 Branch
labels
wangxin
pushed a commit
to wangxin/sonic-mgmt
that referenced
this pull request
Feb 21, 2025
wangxin
pushed a commit
to wangxin/sonic-mgmt
that referenced
this pull request
Feb 21, 2025
Description of PR Summary: Fixes the following error per discussion in sonic-net#16535 UnboundLocalError: local variable 'PFC_STORM_TIMEOUT' referenced before assignment
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Mar 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes the following error per discussion in #16535
UnboundLocalError: local variable 'PFC_STORM_TIMEOUT' referenced before assignmentType of change
Back port request
Approach
What is the motivation for this PR?
fix syntax error in test_pfcwd_function.py:
How did you do it?
How did you verify/test it?
passed on msn2700. failed on 8102.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation