[action] [PR:16535] Fix ASIC check in test_pfcwd_function#16539
Merged
bingwang-ms merged 1 commit intosonic-net:202405from Jan 16, 2025
Merged
[action] [PR:16535] Fix ASIC check in test_pfcwd_function#16539bingwang-ms merged 1 commit intosonic-net:202405from
bingwang-ms merged 1 commit intosonic-net:202405from
Conversation
Collaborator
Author
|
/azp run |
11 tasks
Collaborator
Author
|
Original PR: #16535 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yejianquan
pushed a commit
to yejianquan/sonic-mgmt
that referenced
this pull request
Jan 17, 2025
These changes are picked up in this merge c74b051 (upstream/202405) Fix the test_nhop_group nexthop map for ld DUTs (sonic-net#16166) 3850e85 [dualtor] Fix `testFdbMacLearning` (sonic-net#16549) 4c5b264 Stabilize `test_snmp_fdb_send_tagged` (sonic-net#16409) 9b999f7 Fix ASIC check in test_pfcwd_function (sonic-net#16535) (sonic-net#16539)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
The issue was introduced by PR #15772
The ASIC check is not working as expected because of the syntax error in the code. It should be
ininstead of==sonic-mgmt/tests/pfcwd/test_pfcwd_function.py
Line 757 in 21dbd80
The issue will cause PFCWD function not stable on some platform.
Type of change
Back port request
Approach
What is the motivation for this PR?
This PR is to fix a syntax issue in
test_pfcwd_function.py.How did you do it?
Fix the syntax.
How did you verify/test it?
The change is verified on a physical testbed.
Any platform specific information?
No.
Supported testbed topology if it's a new test case?
Not a new test.
Documentation