[action] [PR:16428] refactor: optimize qos sai test#16488
Merged
mssonicbld merged 1 commit intosonic-net:202411from Jan 13, 2025
Merged
[action] [PR:16428] refactor: optimize qos sai test#16488mssonicbld merged 1 commit intosonic-net:202411from
mssonicbld merged 1 commit intosonic-net:202411from
Conversation
Description of PR Optimize the qos/test_qos_sai.py test to reduce the running time. Summary: Fixes # (issue) Microsoft ADO 30056122 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Add ownership here(Microsft required only) Test case improvement Approach What is the motivation for this PR? The running time of the qos/test_qos_sai.py test is too long (~9h) on T2 chassis so we wanted to reduce the running time. With this implementation, the running time will be reduced to (~7.5h) How did you do it? How did you verify/test it? I ran the updated code and can confirm it's working well on T2 chassis: Elastictest link. The 2 DWRR failures are expected, which will be fixed after sonic-net#16199 I also ran a T1 regression test to confirm: Elastictest link co-authorized by: jianquanye@microsoft.com
Collaborator
Author
|
/azp run |
12 tasks
Collaborator
Author
|
Original PR: #16428 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Optimize the
qos/test_qos_sai.pytest to reduce the running time.Summary:
Fixes # (issue) Microsoft ADO 30056122
Type of change
Back port request
Approach
What is the motivation for this PR?
The running time of the
qos/test_qos_sai.pytest is too long (~9h) on T2 chassis so we wanted to reduce the running time. With this implementation, the running time will be reduced to (~7.5h)How did you do it?
How did you verify/test it?
I ran the updated code and can confirm it's working well on T2 chassis: Elastictest link. The 2 DWRR failures are expected, which will be fixed after #16199
I also ran a T1 regression test to confirm: Elastictest link
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation