[action] [PR:16159] Add pfc-timer-set to 500mS for pfcwd tests.#16469
Merged
mssonicbld merged 1 commit intosonic-net:202405from Jan 13, 2025
Merged
[action] [PR:16159] Add pfc-timer-set to 500mS for pfcwd tests.#16469mssonicbld merged 1 commit intosonic-net:202405from
mssonicbld merged 1 commit intosonic-net:202405from
Conversation
Description of PR Summary: Fixes the flakiness of pfc_gen in pfcwd scripts for cisco-8000. We use a new debug CLI script to force the DUT to wait longer in case of a miss in pfc packets from the fanout due to pfc_gen script. So even if the pfc_gen/fanout misses a couple of pfc frames to DUT, the dut would still not send out data packets. Approach What is the motivation for this PR? Flakiness of pfc-gen. Particularly with 400G links. How did you do it? We have added a new dshell based script that will force the DUT to wait before transmitting data in case of a miss in pfc pause frames. How did you verify/test it? Ran on our duts, with 100G and 400G. Any platform specific information? The new fix specific only to cisco-8000. co-authorized by: [email protected]
Collaborator
Author
|
/azp run |
Merged
9 tasks
Collaborator
Author
|
Original PR: #16159 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes the flakiness of pfc_gen in pfcwd scripts for cisco-8000. We use a new debug CLI script to force the DUT to wait longer in case of a miss in pfc packets from the fanout due to pfc_gen script. So even if the pfc_gen/fanout misses a couple of pfc frames to DUT, the dut would still not send out data packets.
Type of change
Back port request
Approach
What is the motivation for this PR?
Flakiness of pfc-gen. Particularly with 400G links.
How did you do it?
We have added a new dshell based script that will force the DUT to wait before transmitting data in case of a miss in pfc pause frames.
How did you verify/test it?
Ran on our duts, with 100G and 400G.
Any platform specific information?
The new fix specific only to cisco-8000.