[Impacted Area Based PR testing] Fix script timing with recent test plans#16437
Merged
wangxin merged 2 commits intosonic-net:masterfrom Jan 13, 2025
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yutongzhang-microsoft
changed the title
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wangxin
approved these changes
Jan 13, 2025
12 tasks
wangxin
pushed a commit
that referenced
this pull request
Jan 14, 2025
…est scripts. (#16487) What is the motivation for this PR? In PR #16437, we addressed the script timing issue by selecting the five most recent test plans. However, this caused an incorrect ActualCount, as it was summarizing the number of test cases instead of the test scripts. Since the number of test scripts matches the number of test plans, this PR updates the query to correctly count the test plans. How did you do it? Since the number of test scripts matches the number of test plans, this PR updates the query to correctly count the test plans.
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Mar 15, 2025
…plans (sonic-net#16437) What is the motivation for this PR? In the previous implementation, we retrieved 5 test case entries from Kusto to calculate the total running time of a script. However, the query included the condition | where FilePath == '{script}', and since each script may contain multiple test cases, this approach only sampled 5 random test cases from the script. As a result, the calculated average running time was inaccurate. In this PR, we resolve the issue by selecting the most recent 5 test plans instead, ensuring that we account for all test cases executed in the script. How did you do it? In this PR, we resolve the issue by selecting the most recent 5 test plans instead, ensuring that we account for all test cases executed in the script.
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Mar 15, 2025
…est scripts. (sonic-net#16487) What is the motivation for this PR? In PR sonic-net#16437, we addressed the script timing issue by selecting the five most recent test plans. However, this caused an incorrect ActualCount, as it was summarizing the number of test cases instead of the test scripts. Since the number of test scripts matches the number of test plans, this PR updates the query to correctly count the test plans. How did you do it? Since the number of test scripts matches the number of test plans, this PR updates the query to correctly count the test plans.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
In the previous implementation, we retrieved 5 test case entries from Kusto to calculate the total running time of a script. However, the query included the condition
| where FilePath == '{script}', and since each script may contain multiple test cases, this approach only sampled 5 random test cases from the script. As a result, the calculated average running time was inaccurate. In this PR, we resolve the issue by selecting the most recent 5 test plans instead, ensuring that we account for all test cases executed in the script.Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
In the previous implementation, we retrieved 5 test case entries from Kusto to calculate the total running time of a script. However, the query included the condition
| where FilePath == '{script}', and since each script may contain multiple test cases, this approach only sampled 5 random test cases from the script. As a result, the calculated average running time was inaccurate. In this PR, we resolve the issue by selecting the most recent 5 test plans instead, ensuring that we account for all test cases executed in the script.How did you do it?
In this PR, we resolve the issue by selecting the most recent 5 test plans instead, ensuring that we account for all test cases executed in the script.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation