Skip to content

fix undefined post_reboot_analysis var in runRebootTest#16335

Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom
illia-kotvitskyi:run_reboot_test_fix
Feb 26, 2025
Merged

fix undefined post_reboot_analysis var in runRebootTest#16335
bingwang-ms merged 1 commit intosonic-net:masterfrom
illia-kotvitskyi:run_reboot_test_fix

Conversation

@illia-kotvitskyi
Copy link
Contributor

@illia-kotvitskyi illia-kotvitskyi commented Jan 3, 2025

In case preboot_setup fails in runRebootTest post_reboot_analysis variable won't be defined.
Added default value for post_reboot_analysis var to avoid such an error

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@illia-kotvitskyi
Copy link
Contributor Author

@nhe-NV @roy-sror please review

In case preboot_setup fails in runRebootTest post_reboot_analysis
variable won't be defined.
Added default value for post_reboot_analysis var to avoid such an error
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@bingwang-ms bingwang-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bingwang-ms bingwang-ms merged commit 1ed70a8 into sonic-net:master Feb 26, 2025
16 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Feb 26, 2025
)

In case preboot_setup fails in runRebootTest post_reboot_analysis
variable won't be defined.
Added default value for post_reboot_analysis var to avoid such an error
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202411: #17187

mssonicbld pushed a commit that referenced this pull request Feb 27, 2025
In case preboot_setup fails in runRebootTest post_reboot_analysis
variable won't be defined.
Added default value for post_reboot_analysis var to avoid such an error
nissampa pushed a commit to nissampa/sonic-mgmt_dpu_test that referenced this pull request Mar 4, 2025
)

In case preboot_setup fails in runRebootTest post_reboot_analysis
variable won't be defined.
Added default value for post_reboot_analysis var to avoid such an error
nnelluri-cisco pushed a commit to nnelluri-cisco/sonic-mgmt that referenced this pull request Mar 15, 2025
)

In case preboot_setup fails in runRebootTest post_reboot_analysis
variable won't be defined.
Added default value for post_reboot_analysis var to avoid such an error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants