Fix subnet_decap test condition error#16161
Merged
wangxin merged 1 commit intosonic-net:202411from Dec 19, 2024
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
lipxu
approved these changes
Dec 19, 2024
wangxin
approved these changes
Dec 19, 2024
congh-nvidia
added a commit
to congh-nvidia/sonic-mgmt
that referenced
this pull request
May 8, 2025
Issue sonic-net#16161 is fixed. And some test cases that were failing in active-standby due to issue sonic-net#8272 have been passing in active-active. Only test_active_link_down_downstream_active_soc[active-active] is still failing, but the behavior is not exactly the same as active-standby. Probably we need to debug the failure again in active-active scenario.
congh-nvidia
added a commit
to congh-nvidia/sonic-mgmt
that referenced
this pull request
May 20, 2025
Issue sonic-net#16161 is fixed. And some test cases that were failing in active-standby due to issue sonic-net#8272 have been passing in active-active. Only test_active_link_down_downstream_active_soc[active-active] is still failing, but the behavior is not exactly the same as active-standby. Probably we need to debug the failure again in active-active scenario.
bingwang-ms
pushed a commit
that referenced
this pull request
May 20, 2025
Issue #16161 is fixed. And some test cases that were failing in active-standby due to issue #8272 have been passing in active-active. Only test_active_link_down_downstream_active_soc[active-active] is still failing, but the behavior is not exactly the same as active-standby. Probably we need to debug the failure again in active-active scenario.
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
May 27, 2025
…#18276) Issue sonic-net#16161 is fixed. And some test cases that were failing in active-standby due to issue sonic-net#8272 have been passing in active-active. Only test_active_link_down_downstream_active_soc[active-active] is still failing, but the behavior is not exactly the same as active-standby. Probably we need to debug the failure again in active-active scenario.
mssonicbld
pushed a commit
that referenced
this pull request
May 27, 2025
Issue #16161 is fixed. And some test cases that were failing in active-standby due to issue #8272 have been passing in active-active. Only test_active_link_down_downstream_active_soc[active-active] is still failing, but the behavior is not exactly the same as active-standby. Probably we need to debug the failure again in active-active scenario.
congh-nvidia
added a commit
to congh-nvidia/sonic-mgmt
that referenced
this pull request
May 30, 2025
Issue sonic-net#16161 and sonic-net#8272 are all fixed.
congh-nvidia
added a commit
to congh-nvidia/sonic-mgmt
that referenced
this pull request
May 30, 2025
Issue sonic-net#16161 and sonic-net#8272 are all fixed.
bingwang-ms
pushed a commit
that referenced
this pull request
Jun 4, 2025
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…#18276) Issue sonic-net#16161 is fixed. And some test cases that were failing in active-standby due to issue sonic-net#8272 have been passing in active-active. Only test_active_link_down_downstream_active_soc[active-active] is still failing, but the behavior is not exactly the same as active-standby. Probably we need to debug the failure again in active-active scenario. Signed-off-by: opcoder0 <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…#18276) Issue sonic-net#16161 is fixed. And some test cases that were failing in active-standby due to issue sonic-net#8272 have been passing in active-active. Only test_active_link_down_downstream_active_soc[active-active] is still failing, but the behavior is not exactly the same as active-standby. Probably we need to debug the failure again in active-active scenario. Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…#18276) Issue sonic-net#16161 is fixed. And some test cases that were failing in active-standby due to issue sonic-net#8272 have been passing in active-active. Only test_active_link_down_downstream_active_soc[active-active] is still failing, but the behavior is not exactly the same as active-standby. Probably we need to debug the failure again in active-active scenario. Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…#18276) Issue sonic-net#16161 is fixed. And some test cases that were failing in active-standby due to issue sonic-net#8272 have been passing in active-active. Only test_active_link_down_downstream_active_soc[active-active] is still failing, but the behavior is not exactly the same as active-standby. Probably we need to debug the failure again in active-active scenario. Signed-off-by: Guy Shemesh <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
In PR #16152, we need to skip subnet decap test in PR test if issue not resolved, but conditions should be or, not and
How did you do it?
Set conditions_logical_operator to or
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation