[lag_member] add necessary missed imports to test#16021
Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom Dec 18, 2024
Merged
[lag_member] add necessary missed imports to test#16021liat-grozovik merged 1 commit intosonic-net:masterfrom
liat-grozovik merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: AntonHryshchuk <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
roy-sror
approved these changes
Dec 11, 2024
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 16021 in repo sonic-net/sonic-mgmt |
Contributor
|
/azpw run |
|
Commenter does not have sufficient privileges for PR 16021 in repo sonic-net/sonic-mgmt |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liat-grozovik
approved these changes
Dec 18, 2024
Collaborator
|
@AntonHryshchuk to which branches this fix should get in? |
Contributor
Author
|
@liat-grozovik |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Feb 17, 2025
During movement test to Python 3 (sonic-net#14944), were deleted necessary imports of fixtures with "autouse=True": copy_ptftests_directory copy_arp_responder_py copy_arp_responder_py: The fixture copied required configuration files. The arp responder configurations used in the test by method setup_arp_responder Signed-off-by: AntonHryshchuk <[email protected]>
Collaborator
|
Cherry-pick PR to 202411: #16990 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Feb 17, 2025
During movement test to Python 3 (#14944), were deleted necessary imports of fixtures with "autouse=True": copy_ptftests_directory copy_arp_responder_py copy_arp_responder_py: The fixture copied required configuration files. The arp responder configurations used in the test by method setup_arp_responder Signed-off-by: AntonHryshchuk <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
During movement test to Python 3 (#14944), were deleted necessary imports of fixtures with "autouse=True":
copy_ptftests_directorycopy_arp_responder_pycopy_arp_responder_py:
The fixture copied required configuration files. The arp responder configurations used in the test by method
setup_arp_responderError from test without this fixture:
cmd
supervisorctl restart arp_respondercalled in sonic-mgmt/tests/pc/test_lag_member.py: line 225copy_ptftests_directory:
Error from test without this fixture:
Only when the test is executed with these imports does it pass.
Type of change
Back port request
Approach
What is the motivation for this PR?
Stabilaze lag_member test
How did you do it?
Added removed imports
How did you verify/test it?
Executed on setup
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation