Remove Cisco platform sku-sensors-data#15997
Merged
kevinskwang merged 1 commit intosonic-net:masterfrom Dec 20, 2024
Merged
Conversation
|
@kevinwangsk , can you please review. |
kevinskwang
approved these changes
Dec 20, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 20, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 20, 2024
Collaborator
|
Cherry-pick PR to 202411: #16180 |
Collaborator
|
Cherry-pick PR to 202405: #16181 |
This was referenced Dec 20, 2024
mssonicbld
pushed a commit
that referenced
this pull request
Dec 20, 2024
mssonicbld
pushed a commit
that referenced
this pull request
Dec 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Cisco platforms have migrated away from sensord/lm-sensors in favor of sensormond for better monitoring of sensors. sensor/lm-sensors has been disabled for Cisco platforms, so the sku-sensors-data configurations should be removed so test_sensors.py can pass.
Type of change
Back port request
Approach
What is the motivation for this PR?
Sensor configurations hard-coded into sku-sensors-data are actually dynamic from the OS, so test_sensors.py can start to fail due to varying changes that may change sensor device addresses and naming that are dynamically allocated by the OS. sensormond uses consistent configurations, and SONiC is able to react to alarms from sensors, where sensord/lm-sensors is unable.
How did you do it?
Remove Cisco platform sku-sensors-data configurations.
How did you verify/test it?
Run test_sensors.py
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation
N/A