Skip to content

[202311] Ignore GNMI setup and test cname authorization feature on old image#15924

Closed
liuh-80 wants to merge 2 commits intosonic-net:202311from
liuh-80:dev/liuh/fix_gnmi_cname_test
Closed

[202311] Ignore GNMI setup and test cname authorization feature on old image#15924
liuh-80 wants to merge 2 commits intosonic-net:202311from
liuh-80:dev/liuh/fix_gnmi_cname_test

Conversation

@liuh-80
Copy link
Copy Markdown
Contributor

@liuh-80 liuh-80 commented Dec 6, 2024

Ignore GNMI setup and test cname authorization feature on old image.

Why I did it

GNMI cname authorization feature been cherry-pick to 202311 branch.
Recently some test failed on old image which does not support this feature.

Work item tracking
  • Microsoft ADO: 30343954

How I did it

Ignore GNMI setup and test cname authorization feature on old image.

How to verify it

Pass all test case.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Ignore GNMI setup and test cname authorization feature on old image.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link
Copy Markdown
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/gnmi/test_gnmi.py:4:121: E501 line too long (125 > 120 characters)
tests/gnmi/test_gnmi.py:52:121: E501 line too long (130 > 120 characters)

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@lerry-lee
Copy link
Copy Markdown
Contributor

/azpw run

@liuh-80
Copy link
Copy Markdown
Contributor Author

liuh-80 commented Dec 6, 2024

/azpw run Azure.sonic-mgmt

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run Azure.sonic-mgmt

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80 liuh-80 marked this pull request as ready for review December 9, 2024 02:22
@liuh-80 liuh-80 requested a review from ganglyu December 9, 2024 02:22
@liuh-80 liuh-80 closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants