[action] [PR:15675] [sonic-mgmt][dualtor-aa] Fix fdb/test_fdb_mac_learning.py failures#15784
Merged
mssonicbld merged 1 commit intosonic-net:202405from Nov 28, 2024
Merged
Conversation
…onic-net#15675) * [sonic-mgmt][dualtor-aa] Fix fdb/test_fdb_mac_learning.py failures 1) Add fixture to setup topo in active-standby mode. This is needed to make sure packets goto selected dut (for mac learning to happen correctly). 2) Introduce logic to wait for mux status to become consistent before sending traffic (instead of relying on time.sleep delay). 3) Ignoring "...All port channels failed to come up within 3 minutes" syslog, as test is bringing down portchannels and restores them at the end. * Fix pre-commit check failures. * Update fix to handle non-dualtor case. Muxcable is irrelevant for non-dualtor topologies and thus adding a condition to check for mux status consistency in case of dualtor, otherwise add delay using time.sleep (which is a existing change). * [dualtor-aa] Bringup upstream connectivity for mac learning to happen For active-active dualtor, NIC simulator doesn't install OVS flows for downlink ports until the link status becomes consistent which seems to happen only if upstream connectivity is restored
8 tasks
Collaborator
Author
|
Original PR: #15675 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: [dualtor-aa] Fix "fdb/test_fdb_mac_learning.py" failures
Fixes # https://github.com/aristanetworks/sonic-qual.msft/issues/329
Type of change
Back port request
Approach
What is the motivation for this PR?
Test is currently failing on
dualtor-aatopologies due toPacket sometimes going to unselected dut (due to active-active topology) and thus lead to mac learning failure.
After bringing up interfaces (from shutdown state), there is time.sleep of 30 seconds which seem to be not enough for muxcable status on duthost to become consistent with mux
server_status(seeSERVER_STATUSshown asunknownbelow). We need to wait for SERVER_STATUS to match with STATUS field for mac learning to happen.ERR swss#tunnel_packet_handler.py: All portchannels failed to come up within 3 minutes, exiting.is coming during the test and causing test faiure (as log_analyzer is complaining)How did you do it?
learning to happen correctly).
portchannels.
How did you verify/test it?
Stressed the test on
Arista-7260CX3-D108C8platform withdualtor-aa[-56]deployed and test is passing.Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation