[action] [PR:15634] fix: return all BGP neighbors for config reload#15655
Merged
mssonicbld merged 1 commit intosonic-net:202405from Nov 21, 2024
Merged
[action] [PR:15634] fix: return all BGP neighbors for config reload#15655mssonicbld merged 1 commit intosonic-net:202405from
mssonicbld merged 1 commit intosonic-net:202405from
Conversation
8 tasks
Collaborator
Author
|
Original PR: #15634 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue) #15630: wait_for_bgp is not working in config_reload
Type of change
Back port request
Approach
What is the motivation for this PR?
get_bgp_neighbors_per_asic()only returns BGP neighbors with Established status, so the wait_until always returns directly without any wait.How did you do it?
I fixed the logic and made
get_bgp_neighbors_per_asic()inconfig_reload()to return all BGP neighbors regardless of their status. Then I fixed the logic incheck_bgp_session_state_all_asics()to check if all BGP session states are equal to the target state.How did you verify/test it?
I ran the updated code and can confirm it's now checking all BGP neighbors
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation