Fix routes/test_route_perf.py#15620
Merged
yejianquan merged 1 commit intosonic-net:masterfrom Nov 20, 2024
Merged
Conversation
8 tasks
wenyiz2021
approved these changes
Nov 19, 2024
Contributor
|
@vivekverma-arista thanks for the fix. |
Contributor
could you confirm if the quote work for all testbed |
Contributor
Author
This is a general fix for any switch that has Broadcom chip. This has nothing to do with dualtor or any topology in general. It has to do with the syntax of Broadcom shell |
Collaborator
|
@bingwang-ms for cherrying-pick this to 202405, it's a general fix rather than only on chassis, for fixing #15452 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Nov 21, 2024
Description of PR Summary: Fixes sonic-net#323 Approach What is the motivation for this PR? Regression due to sonic-net#15452 How did you do it? Added missing quotes to the command. How did you verify/test it? Ran route/test_route_perf.py on Arista 7260CX3 platform with dualtor topology. co-authorized by: [email protected]
Collaborator
|
Cherry-pick PR to 202405: #15672 |
8 tasks
StormLiangMS
pushed a commit
that referenced
this pull request
Nov 26, 2024
Description of PR Summary: Fixes #323 Approach What is the motivation for this PR? Regression due to #15452 How did you do it? Added missing quotes to the command. How did you verify/test it? Ran route/test_route_perf.py on Arista 7260CX3 platform with dualtor topology. co-authorized by: [email protected] Co-authored-by: Vivek Verma <[email protected]>
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes #323
Type of change
Back port request
Approach
What is the motivation for this PR?
Regression due to #15452
How did you do it?
Added missing quotes to the command.
How did you verify/test it?
Ran route/test_route_perf.py on Arista 7260CX3 platform with dualtor topology.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation