[acl_config_tests]: Fix ACL config tests.#156
Merged
marian-pritsak merged 1 commit intosonic-net:masterfrom Apr 6, 2017
Merged
[acl_config_tests]: Fix ACL config tests.#156marian-pritsak merged 1 commit intosonic-net:masterfrom
marian-pritsak merged 1 commit intosonic-net:masterfrom
Conversation
Contributor
oleksandrivantsiv
commented
Mar 30, 2017
oleksandrivantsiv
commented
- Remove tests that are not relevant.
- Align tests with the latest ACL code changes
oleksandrivantsiv
force-pushed
the
master
branch
from
becced7 to
f3d1854
Compare
- Remove tests that are not relevant. - Align tests with the latest ACL code changes
oleksandrivantsiv
force-pushed
the
master
branch
from
f3d1854 to
ace4802
Compare
lguohan
pushed a commit
that referenced
this pull request
Aug 3, 2017
- Remove tests that are not relevant. - Align tests with the latest ACL code changes
zhixzhu
pushed a commit
to zhixzhu/sonic-mgmt
that referenced
this pull request
May 1, 2025
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Optimize the `temporarily_disable_route_check()` fixture to avoid having errors when running `route_check.py` Summary: Fixes # (issue) Microsoft ADO 31854875 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [x] Test case improvement ### Back port request - [ ] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [x] 202411 ### Approach #### What is the motivation for this PR? When a test module is running with the `temporarily_disable_route_check()` fixture, it will sometimes get an error when running `route_check.py` at the teardown stage. Therefore, we converted the route check to a timeout function to make sure it can pass within a certain time period. #### How did you do it? #### How did you verify/test it? I ran the updated code and can make sure it's working well. - T1 regression test: https://elastictest.org/scheduler/testplan/67da156532d9ac47c1a58764 - T2 test: https://elastictest.org/scheduler/testplan/67da0f7f32d9ac47c1a5875a #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…nic-net#6352) src/sonic-platform-common 9935fca...8664efc (2): Make sonic_sfp Python2 and Python3 compatible (sonic-net#157) [sffbase.py] Fix to make Python 3-compatible (sonic-net#156) src/sonic-platform-daemons e6c786b...81318f7 (1): [psud] Fix issue where PSU Fan info is not updated in State DB (sonic-net#137) Fixes sonic-net#6341
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
eff5c1c [thermalctld] No need exit thermalcltd when loading invalid policy file (sonic-net#172) 5b6d9c0 [syseepromd] Add unit tests; Refactor to allow for greater unit test coverage (sonic-net#156)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.