fix: fix flaky pfc_storm#15544
Merged
yejianquan merged 1 commit intosonic-net:masterfrom Nov 14, 2024
Merged
Conversation
Signed-off-by: Austin Pham <[email protected]>
rraghav-cisco
approved these changes
Nov 13, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Nov 14, 2024
Description of PR Summary: Fix flaky pfc_storm stom_restored Fixes # (issue) 30115860 Approach What is the motivation for this PR? Currently we detect flaky in detecting storm restore. The reason was because the storm terminated early and restore itself before LogAnalyzer can detect restoration. As a result, we want to keep this to be stormed long enough. After the end of each test case, we have stop_storm so it would be fine. Signed-off-by: Austin Pham <[email protected]>
Collaborator
|
Cherry-pick PR to 202405: #15552 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Nov 15, 2024
Description of PR Summary: Fix flaky pfc_storm stom_restored Fixes # (issue) 30115860 Approach What is the motivation for this PR? Currently we detect flaky in detecting storm restore. The reason was because the storm terminated early and restore itself before LogAnalyzer can detect restoration. As a result, we want to keep this to be stormed long enough. After the end of each test case, we have stop_storm so it would be fine. Signed-off-by: Austin Pham <[email protected]>
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
sreejithsreekumaran
pushed a commit
to sreejithsreekumaran/sonic-mgmt
that referenced
this pull request
Nov 15, 2024
Description of PR Summary: Fix flaky pfc_storm stom_restored Fixes # (issue) 30115860 Approach What is the motivation for this PR? Currently we detect flaky in detecting storm restore. The reason was because the storm terminated early and restore itself before LogAnalyzer can detect restoration. As a result, we want to keep this to be stormed long enough. After the end of each test case, we have stop_storm so it would be fine. Signed-off-by: Austin Pham <[email protected]>
yutongzhang-microsoft
pushed a commit
to yutongzhang-microsoft/sonic-mgmt
that referenced
this pull request
Nov 21, 2024
Description of PR Summary: Fix flaky pfc_storm stom_restored Fixes # (issue) 30115860 Approach What is the motivation for this PR? Currently we detect flaky in detecting storm restore. The reason was because the storm terminated early and restore itself before LogAnalyzer can detect restoration. As a result, we want to keep this to be stormed long enough. After the end of each test case, we have stop_storm so it would be fine. Signed-off-by: Austin Pham <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Fix flaky pfc_storm stom_restored
Fixes # (issue) 30115860
Type of change
Back port request
Approach
What is the motivation for this PR?
Currently we detect flaky in detecting storm restore. The reason was because the storm terminated early and restore itself before LogAnalyzer can detect restoration.
As a result, we want to keep this to be stormed long enough.
After the end of each test case, we have
stop_stormso it would be fine.How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation