[Cherry-pick #13069,14585,14802] qos_yaml j2C+ changes for new _vsq thresholds #15448
Merged
bingwang-ms merged 3 commits intosonic-net:202405from Nov 8, 2024
Merged
Conversation
What is the motivation for this PR? The new MMU settings to enhance performance for RDMA traffic in production. Hence the qos_params needs to be tweaked according to the set buffer profiles. However, the existing sonic-mgmt LossyQueueTest doesn't fairly verify the buffer threshold for headroom for Lossy traffic. As per the new vsq profile setting the XOFF FADT threshold/PG is way lesser than the Nominal headroom, which limits it to not utilize the headroom buffer completely and send pause frames before reaching the MAX headroom limit. Either the test case needs to be improvised by adding more source ports or a new test case should be added to verify the Lossy queue traffic at PG level
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ss_pkt count for lossy profile (sonic-net#14585) Since the dynamic_th-alpha changed from 0 to -4 (400g) & 100g port speed for egress lossy profile. PR #sonic-net/sonic-buildimage#20132 Corresponding changes made in J2C+ qos yaml for t2 -broadcom-dnx
vmittal-msft
approved these changes
Nov 7, 2024
ansrajpu-git
changed the title
Contributor
|
Did a surface review of the cherry picks and they look fine. Just one question. |
kenneth-arista
approved these changes
Nov 7, 2024
arlakshm
approved these changes
Nov 8, 2024
This was referenced Nov 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Cherry-pick PR #13069
Cherry-pick PR#14585
Cherry-pick PR#14802
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation