[pytest/pfc_asym] Convert PFC asymmetric to pytest by yvolynets-mlnx · Pull Request #1534 · sonic-net/sonic-mgmt

yvolynets-mlnx · 2020-04-03T16:42:23Z

Description of PR

Summary: Converted Asymmetric PFC test case from Ansible to PyTest
Fixes # (issue)

Type of change

Bug fix
Testbed and Framework(new/improvement)
[+ ] Test case(new)

Approach

How did you do it?

Converted PFC Asymmetric test case from Ansible to PyTest.
Implementation is based on the test design - sonic-net/SONiC#563

How did you verify/test it?

Tested on the local setup.

py.test --inventory ../ansible/inventory --host-pattern {SWITCH} --module-path ../ansible/library/ --testbed {SWITCH}-t0 --testbed_file ../ansible/testbed.csv pfc_asym/test_pfc_asym.py --show-capture=no --log-cli-level info -ra --server_ports_num=20 --fanout_inventory=lab

Option "--server_ports_num" is optional, default value is 20. Used if there is a need to adjust number of used server ports.

Any platform specific information?

Supported testbed topology if it's a new test case?

T0-*

Documentation

Signed-off-by: Yuriy Volynets <yuriyv@mellanox.com>

lgtm-com · 2020-04-07T15:38:17Z

This pull request introduces 4 alerts and fixes 1 when merging 9519c6a into f8fde6d - view on LGTM.com

new alerts:

3 for Unused local variable
1 for Unused import

fixed alerts:

1 for Unused import

neethajohn

There is a lot of code in here that can be reused by other pfc tests. Can they moved into tests/common/ in a follow up PR? Like pfc storm_template, pfc_storm_runner, deploy_pfc_gen.

neethajohn

Also please fix the LGTM alerts

Signed-off-by: Yuriy Volynets <yuriyv@mellanox.com>

neethajohn · 2020-05-13T15:58:49Z

Can you move this common code commit (fanout, conn graph etc ) to a separate PR?

yvolynets-mlnx · 2020-05-14T10:33:34Z

I've moved fanout code to the new PR.

Depends on PR - #1674.
Merge current PR after #1674 will be merged.

* Created separate PR which adds support of Onyx OS based fanout - sonic-net#1674

…asym_pfc Conflicts: tests/common/devices.py tests/conftest.py

yvolynets-mlnx · 2020-05-14T11:46:20Z

There is a lot of code in here that can be reused by other pfc tests. Can they moved into tests/common/ in a follow up PR? Like pfc storm_template, pfc_storm_runner, deploy_pfc_gen.

Moved.

lgtm-com · 2020-05-14T11:55:05Z

This pull request introduces 4 alerts when merging 3549ddd into f11d076 - view on LGTM.com

new alerts:

3 for Unused import
1 for 'import *' may pollute namespace

Signed-off-by: Yuriy Volynets <yuriyv@mellanox.com>

lgtm-com · 2020-05-14T12:23:36Z

This pull request introduces 1 alert when merging 307469c into f11d076 - view on LGTM.com

new alerts:

1 for 'import *' may pollute namespace

neethajohn

fanout_graph_facts returns a dict now (#1730). Please change the usage in the script accordingly

Signed-off-by: Yuriy Volynets <yuriyv@mellanox.com>

yvolynets-mlnx · 2020-06-05T15:39:01Z

fanout_graph_facts returns a dict now (#1730). Please change the usage in the script accordingly

Fixed.

yvolynets-mlnx · 2020-06-05T15:49:33Z

@neethajohn Please review latest updates, and merge if finished

lgtm-com · 2020-06-05T15:56:48Z

This pull request introduces 2 alerts when merging 54504a8 into 8c8a826 - view on LGTM.com

new alerts:

1 for Unused import
1 for 'import *' may pollute namespace

yvolynets-mlnx · 2020-06-05T15:59:59Z

This pull request introduces 2 alerts when merging 54504a8 into 8c8a826 - view on LGTM.com

new alerts:

1 for Unused import

1 for 'import *' may pollute namespace

This 2 changes done intentionally, so please skip them.

neethajohn · 2020-06-08T17:03:04Z

LGTM. can you fix the merge conflicts?

Signed-off-by: Yuriy Volynets <yuriyv@mellanox.com>

…asym_pfc Conflicts: tests/common/devices.py tests/conftest.py

lgtm-com · 2020-06-09T14:01:41Z

This pull request introduces 2 alerts when merging af4f86e into b2017a6 - view on LGTM.com

new alerts:

1 for Unused import
1 for 'import *' may pollute namespace

neethajohn · 2020-06-09T16:44:46Z

retest this please

yvolynets-mlnx · 2020-06-09T17:09:06Z

retest this please

I've tested :)

NJ> That comment was not for you. Danny is piloting sonic-mgmt PR test. :)

7f50b9815e14d90c02d9dce63fd08d90e25cee3f (HEAD -> 201911, origin/201911) handled update() function of fdb orchagent for FDB FLUSH event (sonic-net#1534) 17adc13b6ca21846fe27c94d6a16f9909c712d77 Add a check for warm-restart, and do a clear only when warm-restart is enable. (sonic-net#1498) d097260a5aa7bd611babd5062e220056374e23d8 Fixed compilation failure with debug option (sonic-net#1518) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>

Converted PFC asymmetric test case from ansible to pytest.

6bf66ae

yvolynets-mlnx changed the title ~~Converted PFC asymmetric test case from ansible to pytest.~~ [pytest/pfc_asym] Convert PFC asymmetric to pytest Apr 3, 2020

Fixed usage of SAI port OIDs

9519c6a

Signed-off-by: Yuriy Volynets <yuriyv@mellanox.com>

lguohan requested a review from neethajohn April 7, 2020 16:19

neethajohn reviewed Apr 20, 2020

View reviewed changes

Comment thread ansible/roles/test/templates/pfc_storm_stop_mlnx.j2

Comment thread tests/common/helpers/general.py

Comment thread tests/pfc_asym/helpers.py Outdated

Comment thread tests/scripts/exec_template.yml

neethajohn reviewed Apr 20, 2020

View reviewed changes

yvolynets-mlnx added 2 commits May 13, 2020 15:42

Created common pfc asym fixtures

79324c7

Signed-off-by: Yuriy Volynets <yuriyv@mellanox.com>

Added MLNXfanout support, refactoring common pfc asym code.

366b13f

yvolynets-mlnx added 2 commits May 14, 2020 11:26

Removed code which adds support of Onyx fanout

7211d16

* Created separate PR which adds support of Onyx OS based fanout - sonic-net#1674

Merge branch 'master' of https://github.com/Azure/sonic-mgmt into pr_…

3549ddd

…asym_pfc Conflicts: tests/common/devices.py tests/conftest.py

Removed outdated imports.

307469c

Signed-off-by: Yuriy Volynets <yuriyv@mellanox.com>

yvolynets-mlnx mentioned this pull request Jun 1, 2020

Added support of Onyx based fanout in 'fanouthosts' fixture #1674

Merged

3 tasks

neethajohn reviewed Jun 3, 2020

View reviewed changes

Fixed fanout graphs usage, merged 'devices.py'

8a04a53

Signed-off-by: Yuriy Volynets <yuriyv@mellanox.com>

Merge branch 'master' into pr_asym_pfc

54504a8

yvolynets-mlnx added 2 commits June 9, 2020 13:21

Fixed merge conflicts

74c0eb7

Signed-off-by: Yuriy Volynets <yuriyv@mellanox.com>

Merge branch 'master' of https://github.com/Azure/sonic-mgmt into pr_…

af4f86e

…asym_pfc Conflicts: tests/common/devices.py tests/conftest.py

neethajohn approved these changes Jun 9, 2020

View reviewed changes

neethajohn added Jenkins-Pilot and removed Jenkins-Pilot labels Jun 9, 2020

neethajohn merged commit bd8715f into sonic-net:master Jun 9, 2020

Conversation

yvolynets-mlnx commented Apr 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Approach

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

lgtm-com bot commented Apr 7, 2020

Uh oh!

neethajohn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

neethajohn left a comment

Choose a reason for hiding this comment

Uh oh!

neethajohn commented May 13, 2020

Uh oh!

yvolynets-mlnx commented May 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yvolynets-mlnx commented May 14, 2020

Uh oh!

lgtm-com bot commented May 14, 2020

Uh oh!

lgtm-com bot commented May 14, 2020

Uh oh!

neethajohn left a comment

Choose a reason for hiding this comment

Uh oh!

yvolynets-mlnx commented Jun 5, 2020

Uh oh!

yvolynets-mlnx commented Jun 5, 2020

Uh oh!

lgtm-com bot commented Jun 5, 2020

Uh oh!

yvolynets-mlnx commented Jun 5, 2020

Uh oh!

neethajohn commented Jun 8, 2020

Uh oh!

lgtm-com bot commented Jun 9, 2020

Uh oh!

neethajohn commented Jun 9, 2020

Uh oh!

yvolynets-mlnx commented Jun 9, 2020 • edited by neethajohn Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yvolynets-mlnx commented Apr 3, 2020 •

edited

Loading

yvolynets-mlnx commented May 14, 2020 •

edited

Loading

yvolynets-mlnx commented Jun 9, 2020 •

edited by neethajohn

Loading