Fix test_check_show_lpmode case#15062
Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom Nov 6, 2024
Merged
Conversation
Collaborator
|
@prgeor Can you help review? |
Contributor
|
@mihirpat1 can review? |
mihirpat1
approved these changes
Oct 31, 2024
Contributor
Author
|
Hi @bingwang-ms , @mihirpat1 had approved the change, could you help merge it, thanks! |
bingwang-ms
approved these changes
Oct 31, 2024
Collaborator
|
/azp run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
PR checker got stuck. Just re-triggered it |
Collaborator
|
@weiguo-nvidia PR conflicts with 202405 branch |
8 tasks
Contributor
Author
Hi @mssonicbld , I create PR #15417 to submit the same fix in 202405 branch, could you help review it? |
veronica-arista
pushed a commit
to veronica-arista/sonic-mgmt
that referenced
this pull request
Nov 7, 2024
sreejithsreekumaran
pushed a commit
to sreejithsreekumaran/sonic-mgmt
that referenced
this pull request
Nov 15, 2024
yutongzhang-microsoft
pushed a commit
to yutongzhang-microsoft/sonic-mgmt
that referenced
this pull request
Nov 21, 2024
wangxin
pushed a commit
that referenced
this pull request
Nov 27, 2024
Fixes # PR #15062 fix the test_check_show_lpmode case and merge in master branch, but conflicts with 202405 branch. So create this PR to submit the code to 202405 branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Fix test_check_show_lpmode case
Fixes # (issue)
test_check_show_lpmodecase usexcvr_skip_listfunction to check lpmode for only supported interface, but the code passes all the output ofshow interface transceiver lpmodetovalidate_transceiver_lpmodefunction, then the function checks each interface lpmode. This is incorrect. Fix it.For example, if the interface lpmode is like this "
['Ethernet0 N/A', 'Ethernet1 Off']", Ethernet0 is RJ45 and no lpmode check is needed. Ethernet1 needs to check lpmode(['Ethernet0 N/A', 'Ethernet1 Off'])of the command to the functionvalidate_transceiver_lpmode. It checks each item and finds that Ethernet0 lpmode is "N/A", then the case fails. This is incorrectcheck if header exists" test fromvalidate_transceiver_lpmodetotest_check_show_lpmode. So the header only check one time.Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation