Relocate log_custom_msg to assure test results to be logged#15007
Merged
yejianquan merged 1 commit intosonic-net:masterfrom Oct 17, 2024
Merged
Relocate log_custom_msg to assure test results to be logged#15007yejianquan merged 1 commit intosonic-net:masterfrom
yejianquan merged 1 commit intosonic-net:masterfrom
Conversation
yejianquan
requested changes
Oct 16, 2024
augusdn
force-pushed
the
custom_log_v2
branch
from
8314f2f to
ac9d2cf
Compare
yejianquan
reviewed
Oct 17, 2024
yejianquan
previously approved these changes
Oct 17, 2024
Collaborator
yejianquan
left a comment
yejianquan
left a comment
There was a problem hiding this comment.
fake approve to start PR test
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
augusdn
force-pushed
the
custom_log_v2
branch
2 times, most recently
from
914b30b to
f09ca35
Compare
yejianquan
reviewed
Oct 17, 2024
augusdn
force-pushed
the
custom_log_v2
branch
from
f09ca35 to
e69d310
Compare
Instead of fixture, log_custom_msg is now called in one of hook (pytest_runtest_makereport). This is to prevent unexpected sequence of fixture teardown observed in nightly. Calling log_custom_msg from pytest_runtest_makereport will be one of the very last hooks to be called for each test.
augusdn
force-pushed
the
custom_log_v2
branch
from
e69d310 to
3bbf15e
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Oct 17, 2024
…t#15007) Instead of fixture, log_custom_msg is now called in one of hook (pytest_runtest_makereport). This is to prevent unexpected sequence of fixture teardown observed in nightly. Calling log_custom_msg from pytest_runtest_makereport will be one of the very last hooks to be called for each test. Description of PR Summary: Instead of fixture, log_custom_msg is now called in one of hook (pytest_runtest_makereport). This is to prevent unexpected sequence of fixture teardown observed in nightly. Calling log_custom_msg from pytest_runtest_makereport will be one of the very last hooks to be called for each test. Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 202012 202205 202305 202311 202405 Approach What is the motivation for this PR? log_custom_msg being called before post_sanity_check How did you do it? instead of fixture log_custom_msg, relocated the call to pytest_runtest_makereport How did you verify/test it? elastic-test using testplan co-authorized by: [email protected]
Collaborator
|
Cherry-pick PR to 202405: #15033 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Oct 17, 2024
Instead of fixture, log_custom_msg is now called in one of hook (pytest_runtest_makereport). This is to prevent unexpected sequence of fixture teardown observed in nightly. Calling log_custom_msg from pytest_runtest_makereport will be one of the very last hooks to be called for each test. Description of PR Summary: Instead of fixture, log_custom_msg is now called in one of hook (pytest_runtest_makereport). This is to prevent unexpected sequence of fixture teardown observed in nightly. Calling log_custom_msg from pytest_runtest_makereport will be one of the very last hooks to be called for each test. Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 202012 202205 202305 202311 202405 Approach What is the motivation for this PR? log_custom_msg being called before post_sanity_check How did you do it? instead of fixture log_custom_msg, relocated the call to pytest_runtest_makereport How did you verify/test it? elastic-test using testplan co-authorized by: [email protected]
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
vikshaw-Nokia
pushed a commit
to vikshaw-Nokia/sonic-mgmt
that referenced
this pull request
Oct 23, 2024
…t#15007) Instead of fixture, log_custom_msg is now called in one of hook (pytest_runtest_makereport). This is to prevent unexpected sequence of fixture teardown observed in nightly. Calling log_custom_msg from pytest_runtest_makereport will be one of the very last hooks to be called for each test. Description of PR Summary: Instead of fixture, log_custom_msg is now called in one of hook (pytest_runtest_makereport). This is to prevent unexpected sequence of fixture teardown observed in nightly. Calling log_custom_msg from pytest_runtest_makereport will be one of the very last hooks to be called for each test. Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 202012 202205 202305 202311 202405 Approach What is the motivation for this PR? log_custom_msg being called before post_sanity_check How did you do it? instead of fixture log_custom_msg, relocated the call to pytest_runtest_makereport How did you verify/test it? elastic-test using testplan co-authorized by: [email protected]
sreejithsreekumaran
pushed a commit
to sreejithsreekumaran/sonic-mgmt
that referenced
this pull request
Nov 15, 2024
…t#15007) Instead of fixture, log_custom_msg is now called in one of hook (pytest_runtest_makereport). This is to prevent unexpected sequence of fixture teardown observed in nightly. Calling log_custom_msg from pytest_runtest_makereport will be one of the very last hooks to be called for each test. Description of PR Summary: Instead of fixture, log_custom_msg is now called in one of hook (pytest_runtest_makereport). This is to prevent unexpected sequence of fixture teardown observed in nightly. Calling log_custom_msg from pytest_runtest_makereport will be one of the very last hooks to be called for each test. Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 202012 202205 202305 202311 202405 Approach What is the motivation for this PR? log_custom_msg being called before post_sanity_check How did you do it? instead of fixture log_custom_msg, relocated the call to pytest_runtest_makereport How did you verify/test it? elastic-test using testplan co-authorized by: [email protected]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of fixture, log_custom_msg is now called in one of hook (pytest_runtest_makereport). This is to prevent unexpected sequence of fixture teardown observed in nightly. Calling log_custom_msg from pytest_runtest_makereport will be one of the very last hooks to be called for each test.
Description of PR
Summary:
Instead of fixture, log_custom_msg is now called in one of hook (pytest_runtest_makereport). This is to prevent unexpected sequence of fixture teardown observed in nightly. Calling log_custom_msg from pytest_runtest_makereport will be one of the very last hooks to be called for each test.
Type of change
Back port request
Approach
What is the motivation for this PR?
log_custom_msg being called before post_sanity_check
How did you do it?
instead of fixture log_custom_msg, relocated the call to pytest_runtest_makereport
How did you verify/test it?
elastic-test using testplan
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation