Implement new TC for SNMP ifErrors/ifDiscard

[SavchukRomanLv]

Description of PR

Summary:
Depends on: #(#14019)
Fixes # (sonic-net/sonic-snmpagent#325)
After these change we need to implement new logic for SNMP ifErrors/ifDiscard

Type of change

• Bug fix
• Testbed and Framework(new/improvement)
• Test case(new/improvement)

Back port request

• 202012
• 202205
• 202305
• 202311
• 202405

Approach

What is the motivation for this PR?

Cover new logic for SNMP for ifErrors/ifDiscard counters

How did you do it?

Add new TC

How did you verify/test it?

Run TC, TC passed

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

[mssonicbld]

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/snmp/test_snmp_interfaces.py:3:1: F401 'ipaddress' imported but unused
tests/snmp/test_snmp_interfaces.py:42:1: E302 expected 2 blank lines, found 1
tests/snmp/test_snmp_interfaces.py:46:121: E501 line too long (122 > 120 characters)
tests/snmp/test_snmp_interfaces.py:333:5: F841 local variable 'namespace' is assigned to but never used
tests/snmp/test_snmp_interfaces.py:342:17: F541 f-string is missing placeholders
tests/snmp/test_snmp_interfaces.py:359:17: F541 f-string is missing placeholders
tests/snmp/test_snmp_interfaces.py:365:17: F541 f-string is missing placeholders
tests/snmp/test_snmp_interfaces.py:379:5: F841 local variable 'minigraph_port_name_to_alias_map' is assigned to but never used
tests/snmp/test_snmp_interfaces.py:384:53: E127 continuation line over-indented for visual indent
tests/snmp/test_snmp_interfaces.py:388:54: E127 continuation line over-indented for visual indent
...
[truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
   the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
   docker container.
2. Ensure that the pre-commit package is installed:

sudo pip install pre-commit

3. Go to repository root folder
4. Install the pre-commit hooks:

pre-commit install

5. Use pre-commit to check staged file:

pre-commit

6. Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

[mssonicbld]

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/snmp/test_snmp_interfaces.py:334:5: F841 local variable 'namespace' is assigned to but never used

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
   the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
   docker container.
2. Ensure that the pre-commit package is installed:

sudo pip install pre-commit

3. Go to repository root folder
4. Install the pre-commit hooks:

pre-commit install

5. Use pre-commit to check staged file:

pre-commit

6. Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

[mssonicbld]

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/snmp/test_snmp_interfaces.py:380:66: F821 undefined name 'minigraph_port_name_to_alias_map'

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
   the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
   docker container.
2. Ensure that the pre-commit package is installed:

sudo pip install pre-commit

3. Go to repository root folder
4. Install the pre-commit hooks:

pre-commit install

5. Use pre-commit to check staged file:

pre-commit

6. Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[SavchukRomanLv]

Hi @bingwang-ms I do see There is a cross-feature dependence. File: tests/snmp/test_snmp_interfaces.py, import module: tests.platform_tests.counterpoll.counterpoll_helper

how community deal with such problem , as I need already created function from counterpoll and do not want to duplicate or break existing logic. Can you share some example? Thank you in advance.

[mssonicbld]

@SavchukRomanLv PR conflicts with 202505 branch

[r12f]

hi @SavchukRomanLv , do you mind to help pick this change to 202412?

[illia-kotvitskyi]

hi @SavchukRomanLv , do you mind to help pick this change to 202412?

Hi @r12f,
This change depends on some changes introduced in #18906
Is it also relevant for 202412?

[r12f]

hi @illia-kotvitskyi , it doesn't look like so, we are not using SAI_NOT_DROP_SIP_DIP_LINK_LOCAL=1 in sai.profile in 202412.

[illia-kotvitskyi]

Cherry-pick to 202412 is created, please help to review and merge:
Azure/sonic-mgmt.msft#653

[r12f]

thanks @illia-kotvitskyi ! kicked off CI

[r12f]

hi @illia-kotvitskyi , CI failed on the 202412 cherry pick. do you mind to help resolve it?

[illia-kotvitskyi]

Hi @r12f ,

I need your help to rerun the CI since I don't have permission for that

[r12f]

gotcha! kicked off again

[r12f]

CI status is somehow lost... kicked it off again.