Skip to content

Revert PR:12186 crm_stats_ipv6_route_available counter was not decremented, as we have a fix in platform side of code #14775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yejianquan merged 1 commit into from
Sep 27, 2024
Merged

Revert PR:12186 crm_stats_ipv6_route_available counter was not decremented, as we have a fix in platform side of code #14775

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions tests/crm/test_crm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,10 +517,6 @@ def test_crm_route(duthosts, enum_rand_one_per_hwsku_frontend_hostname, enum_fro
logging.info("route add cmd: {}".format(route_add))
duthost.command(route_add)

if is_cisco_device(duthost):
# Sleep more time after route add
time.sleep(10)

check_available_counters = True
if duthost.facts['asic_type'] == 'broadcom':
check_available_counters = False
Expand All @@ -546,9 +542,7 @@ def test_crm_route(duthosts, enum_rand_one_per_hwsku_frontend_hostname, enum_fro
RESTORE_CMDS["test_crm_route"].append(route_del_cmd.format(asichost.ip_cmd, i, nh_ip))
pytest.fail("\"crm_stats_ipv{}_route_used\" counter was not incremented".format(ip_ver))
# Verify "crm_stats_ipv[4/6]_route_available" counter was decremented
# For Cisco-8000 devices, hardware counters are statistical-based with +/- 1 entry tolerance.
# Hence, the available counter may not increase as per initial value.
if check_available_counters and not (crm_stats_route_available - new_crm_stats_route_available > 1):
if check_available_counters and not (crm_stats_route_available - new_crm_stats_route_available >= 1):
if is_mellanox_device(duthost):
# Get sai sdk dump file in case test fail, we can get the LPM tree information
get_sai_sdk_dump_file(duthost, f"sai_sdk_dump_after_add_v{ip_ver}_router")
Expand Down