Skip test_telemetry_queue_buffer_cnt test if switch type is voq#14694
Merged
bingwang-ms merged 11 commits intosonic-net:masterfrom Oct 17, 2024
wumiaont:queue_count
Merged
Skip test_telemetry_queue_buffer_cnt test if switch type is voq#14694bingwang-ms merged 11 commits intosonic-net:masterfrom wumiaont:queue_count
bingwang-ms merged 11 commits intosonic-net:masterfrom
wumiaont:queue_count
Conversation
This reverts commit 1a14165.
arlakshm
reviewed
Sep 25, 2024
vmittal-msft
approved these changes
Sep 27, 2024
Contributor
vmittal-msft
left a comment
vmittal-msft
left a comment
There was a problem hiding this comment.
We may need to revisit once we fix issue in the orchagent for voq chassis.
8 tasks
Collaborator
|
@yutongzhang-microsoft Can you please review this change? Thanks |
yatishkoul
approved these changes
Oct 14, 2024
Contributor
yatishkoul
left a comment
yatishkoul
left a comment
There was a problem hiding this comment.
After skipping this test, all the other telemetry tests pass on 202405.
8 tasks
zbud-msft
approved these changes
Oct 14, 2024
arlakshm
approved these changes
Oct 14, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Oct 17, 2024
…c-net#14694) * Fix syslog test failure about fixture tbinfo
Collaborator
|
Cherry-pick PR to 202405: #15036 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Oct 17, 2024
* Fix syslog test failure about fixture tbinfo
vikshaw-Nokia
pushed a commit
to vikshaw-Nokia/sonic-mgmt
that referenced
this pull request
Oct 23, 2024
…c-net#14694) * Fix syslog test failure about fixture tbinfo
sreejithsreekumaran
pushed a commit
to sreejithsreekumaran/sonic-mgmt
that referenced
this pull request
Nov 15, 2024
…c-net#14694) * Fix syslog test failure about fixture tbinfo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If switch type is voq, it will not support config buffer queue from config. We should skip test_telemetry_queue_buffer_cnt in this case.
Summary:
Fixes # (issue) 19624
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix the test failure
How did you do it?
skip test_telemetry_queue_buffer_cnt test if switch type is voq
How did you verify/test it?
Test the script and test case skipped in the case the switch Nokia 7250 (voq).