[dualtor] Add test to simulate server reboot#14690
Merged
wangxin merged 7 commits intosonic-net:masterfrom Oct 25, 2024
Merged
Conversation
zjswhhh
reviewed
Sep 23, 2024
Contributor
There was a problem hiding this comment.
Seems that your change didn't cover scenario 1.
The goal is to confirm when one ToR toggles mux direction, the other ToR will be in sync eventually even without icmp heartbeats.
Scenario 1 link flap after boot up.
One side ToR toggles mux, and the other side is able to sync up in short amount of time.
Comment on lines
+101
to
+109
| def upper_tor_mux_state_verification(state, health): | ||
| mux_state_upper_tor = show_muxcable_status(upper_tor_host) | ||
| return (mux_state_upper_tor[test_iface]['status'] == state and | ||
| mux_state_upper_tor[test_iface]['health'] == health) | ||
|
|
||
| def lower_tor_mux_state_verfication(state, health): | ||
| mux_state_lower_tor = show_muxcable_status(lower_tor_host) | ||
| return (mux_state_lower_tor[test_iface]['status'] == state and | ||
| mux_state_lower_tor[test_iface]['health'] == health) |
Contributor
There was a problem hiding this comment.
can you try using dualtor test utilities?
sonic-mgmt/tests/common/dualtor/control_plane_utils.py
Lines 255 to 261 in b6d4924
Contributor
|
Hi @opcoder0 - can you address the PR checker failure? |
wangxin
previously approved these changes
Oct 24, 2024
Contributor
Author
Thanks @zjswhhh fixed. It shouldn't have run on |
wangxin
approved these changes
Oct 25, 2024
sreejithsreekumaran
pushed a commit
to sreejithsreekumaran/sonic-mgmt
that referenced
this pull request
Nov 15, 2024
Add test to simulate server reboot via restart of icmp_responder and verify that the TORs get back to healthy status after the restart is complete.
yutongzhang-microsoft
pushed a commit
to yutongzhang-microsoft/sonic-mgmt
that referenced
this pull request
Nov 21, 2024
Add test to simulate server reboot via restart of icmp_responder and verify that the TORs get back to healthy status after the restart is complete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Add test to simulate server reboot via restart of
icmp_responderand verify that the TORs get back tohealthystatus after the restart is complete.Summary:
Fixes #12039
Type of change
Back port request
Approach
What is the motivation for this PR?
Address test gap.
How did you do it?
Add test to simulate server reboot via shutdown of
icmp_responderservice and verified that the TOR health is back to normal after reboot is complete.How did you verify/test it?
Ran tests on dualtor-aa testbeds.
Any platform specific information?
None
Supported testbed topology if it's a new test case?
dualtor
Documentation
None