Add conditional check to skip snmp lldp pytest case when topo is ptf32 or ptf64.

[EmmaLin11]

Description of PR

Summary:
Add conditional check to skip snmp lldp pytest case when topo is ptf32 or ptf64.

When topo is ptf32 or ptf64, snmp lldp pytest will failed. Because there are no lldp data respond from sonic device. The topologies for lldp does not include ptf32 and ptf64 on testcase.yml. Thus the ptf32 and ptf64 topo shall be skipped.

Type of change

• [v] Bug fix
• [] Testbed and Framework(new/improvement)
• [] Test case(new/improvement)

Approach

How did you do it?

Add conditional check to skip snmp lldp pytest case when topo is ptf32 or ptf64

How did you verify/test it?

Perform pytest to confirm snmp lldp is skipped when topo is ptf32 or ptf64.

sonic@2501de585901:~/sonic-mgmt/tests$ py.test --inventory=lab --host-pattern=2-9_ptf32  --module-path ../ansible/library/ --testbed=2-9_ptf32  --testbed_file =testbed.csv snmp/test_snmp_lldp.py -log-cli-level=INFO --log-level=DEBUG -v  --show-capture=stdout --duration=0
==================================================================== test session starts =====================================================================
platform linux2 -- Python 2.7.12, pytest-4.6.7, py-1.8.0, pluggy-0.13.1 -- /usr/bin/python
cachedir: .pytest_cache
ansible: 2.8.7
rootdir: /var/sonic/sonic-mgmt/tests, inifile: pytest.ini
plugins: ansible-2.2.2
collecting ... collected 1 item                                                                                                                                             

snmp/test_snmp_lldp.py::test_snmp_interfaces SKIPPED                                                                                                   [100%]

=================================================================== slowest test durations ===================================================================
1.66s setup    snmp/test_snmp_lldp.py::test_snmp_interfaces

(0.00 durations hidden.  Use -vv to show these durations.)
================================================================= 1 skipped in 1.67 seconds ==================================================================

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

N/A

Documentation

N/A

[lguohan]

@wangxin , I do not know if this is the best way to skip a test for a testbed. I do not like ptf32, ptf64, too many ptf, we should at least skip all ptf testbeds. maybe it is better to define a function to check the testbed type, only ptf, t0, t1. then, we can then filter the test based on testbed type.

[lguohan]

this is difficult to maintain. we should at least define a function get_testbed_type(), and only three type should be returned t1, t0, and ptf.

[EmmaLin11]

@lguohan , I get it. I defined get_testbed_type() for it. But I have some questions. What is the type of this function? It's a common function? If yes, where should I define this function? Could you give me some advice? Thanks.

[wangxin]

Would you please consider adding a field to the object created in class TestbddInfo which is defined in tests/conftest.py. For example:

class TestbedInfo(object):
    ...

def __init__(self, testbed_file):
    ...
    line['topo']['type'] = self.get_testbed_type()

def get_testbed_type(self):
    ...

Then in test scripts, you can access it using testbed['topo']['type'].

[EmmaLin11]

@wangxin , thank you for your advice. I added a field 'type' to the object created in class TestbddInfo which is defined in tests/conftest.py to identify testbed type. Could you please review it?

[lguohan]

second, i like the mark introduced in the pytest.ini, for example bsl. Then, we can use that mark to filter which test to run instead of using this skip.

for example, another requirement is to run all tests that allowed to run in t0 testbed. how do we specify that?

[lguohan]

suggest to use regex match somehting like ("^(t0|t1|ptf)[-]")?

[EmmaLin11]

@lguohan , thank you for your advice. I change to use regex match() to check if topo_name matches expected topo_type. Could you please review it?

[lguohan]

once you change to use regex then, i am good.