Full Mesh Traffic Sanity verification #14678
Open
sreejithsreekumaran wants to merge 2 commits intosonic-net:202311from
Open
Full Mesh Traffic Sanity verification #14678sreejithsreekumaran wants to merge 2 commits intosonic-net:202311from
sreejithsreekumaran wants to merge 2 commits intosonic-net:202311from
Conversation
* Added testcase to run traffic in full mesh from all src to all dst port pair. After all src inject traffic to a given dst, queue counters are verified for any drop * Removed the unwanted Try block Fixed a bug in longest prefix match in conditional_mark Added conditional mark to skip if not ptf64 topo * Made adding static routes a pytest fixture * Added fixture to configure ip on ptf interfaces while using PTF64 topo * Changed to skip for all platforms except Cisco * flake8 issues reported from changes in PR 9896
8 tasks
kevinskwang
previously approved these changes
Sep 27, 2024
kevinskwang
reviewed
Sep 29, 2024
| # condition is a dict which has only one item, so we use condition.keys()[0] to get its key. | ||
| if nodeid.startswith(list(condition.keys())[0]): | ||
| length = len(condition) | ||
| length = len(list(condition.keys())[0]) |
Contributor
There was a problem hiding this comment.
what does this line change's purpose?
Contributor
Author
There was a problem hiding this comment.
condition a dict with a single item and its length will always be 1 irrespective of how many rules are present.
So the key length should be checked, not the length of dict, to find the longest prefix match key.
Contributor
There was a problem hiding this comment.
did you aware of this change will make the current skipped case to be run?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
A test to check reachability from any source port to any destination port in the device for each traffic class.
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
ptf64 topology is used to have 64 ports of the DUT connected
to 64 PTF ports.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation