Refactor thermal_control_test_helper.py from folder tests/platform_tests to tests/common/helpers#14588
Merged
wangxin merged 5 commits intosonic-net:masterfrom Sep 18, 2024
Conversation
yutongzhang-microsoft
force-pushed
the
yutongzhang/refactor_thermal_control_test_helper
branch
from
7cb6a6a to
16ccac4
Compare
wangxin
approved these changes
Sep 18, 2024
yutongzhang-microsoft
deleted the
yutongzhang/refactor_thermal_control_test_helper
branch
hdwhdw
pushed a commit
to hdwhdw/sonic-mgmt
that referenced
this pull request
Sep 20, 2024
…_tests` to `tests/common/helpers` (sonic-net#14588) What is the motivation for this PR? Some scripts use the shared functions in thermal_control_test_helper.py. To minimize cross-module dependencies, we move this helper script from feature specific folder tests/platform_tests to common folder tests/common/helpers. How did you do it? Some scripts use the shared functions in thermal_control_test_helper.py. To minimize cross-module dependencies, we move this helper script from feature specific folder tests/platform_tests to common folder tests/common/helpers.
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
…_tests` to `tests/common/helpers` (sonic-net#14588) What is the motivation for this PR? Some scripts use the shared functions in thermal_control_test_helper.py. To minimize cross-module dependencies, we move this helper script from feature specific folder tests/platform_tests to common folder tests/common/helpers. How did you do it? Some scripts use the shared functions in thermal_control_test_helper.py. To minimize cross-module dependencies, we move this helper script from feature specific folder tests/platform_tests to common folder tests/common/helpers.
vikshaw-Nokia
pushed a commit
to vikshaw-Nokia/sonic-mgmt
that referenced
this pull request
Oct 23, 2024
…_tests` to `tests/common/helpers` (sonic-net#14588) What is the motivation for this PR? Some scripts use the shared functions in thermal_control_test_helper.py. To minimize cross-module dependencies, we move this helper script from feature specific folder tests/platform_tests to common folder tests/common/helpers. How did you do it? Some scripts use the shared functions in thermal_control_test_helper.py. To minimize cross-module dependencies, we move this helper script from feature specific folder tests/platform_tests to common folder tests/common/helpers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Some scripts use the shared functions in
thermal_control_test_helper.py. To minimize cross-module dependencies, we move this helper script from feature specific foldertests/platform_teststo common foldertests/common/helpers.Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Some scripts use the shared functions in
thermal_control_test_helper.py. To minimize cross-module dependencies, we move this helper script from feature specific foldertests/platform_teststo common foldertests/common/helpers.How did you do it?
Some scripts use the shared functions in
thermal_control_test_helper.py. To minimize cross-module dependencies, we move this helper script from feature specific foldertests/platform_teststo common foldertests/common/helpers.How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation