Add static route ASIC DB check for test_nhop_group test#14475
Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom Nov 6, 2024
Merged
Add static route ASIC DB check for test_nhop_group test#14475bingwang-ms merged 1 commit intosonic-net:masterfrom
bingwang-ms merged 1 commit intosonic-net:masterfrom
Conversation
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
bingwang-ms
reviewed
Oct 23, 2024
Add the static route validation in cases of weak switch Change-Id: I83f2a9a2318adbf901b94f82dcc39b9362d43f78
echuawu
force-pushed
the
update_nhop_script
branch
from
be11417 to
a352b52
Compare
bingwang-ms
reviewed
Oct 31, 2024
|
|
||
| def validate_asic_route(duthost, route, exist=True): | ||
| logger.info(f"Checking ip route: {route}") | ||
| asic_info = duthost.shell(f'redis-cli -n 1 keys "ASIC_STATE:SAI_OBJECT_TYPE_ROUTE_ENTRY:*{route}*"', |
Collaborator
There was a problem hiding this comment.
Why do we need * here?
Contributor
Author
There was a problem hiding this comment.
@bingwang-ms , it's based on the test result.
bingwang-ms
approved these changes
Nov 6, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Nov 6, 2024
Add the static route validation in cases of weak switch Change-Id: I83f2a9a2318adbf901b94f82dcc39b9362d43f78
Collaborator
|
Cherry-pick PR to 202405: #15373 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Nov 6, 2024
Add the static route validation in cases of weak switch Change-Id: I83f2a9a2318adbf901b94f82dcc39b9362d43f78
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
veronica-arista
pushed a commit
to veronica-arista/sonic-mgmt
that referenced
this pull request
Nov 7, 2024
Add the static route validation in cases of weak switch Change-Id: I83f2a9a2318adbf901b94f82dcc39b9362d43f78
sreejithsreekumaran
pushed a commit
to sreejithsreekumaran/sonic-mgmt
that referenced
this pull request
Nov 15, 2024
Add the static route validation in cases of weak switch Change-Id: I83f2a9a2318adbf901b94f82dcc39b9362d43f78
yutongzhang-microsoft
pushed a commit
to yutongzhang-microsoft/sonic-mgmt
that referenced
this pull request
Nov 21, 2024
Add the static route validation in cases of weak switch Change-Id: I83f2a9a2318adbf901b94f82dcc39b9362d43f78
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Add the static route ASIC DB validation in cases of weak switch
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
For some weak CPU switch, such as Mellanox SN2700 with A0 chip type. The fixed 15 seconds is not enough to handle a bunch of BGP route add/delete and static route add/delete. So the case would failed from time to time.
How did you do it?
Add a ASIC DB check for the static route validation.
How did you verify/test it?
Run it in internal regression.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation