Stabilize PFC watchdog test#14425
Merged
bingwang-ms merged 2 commits intosonic-net:masterfrom Sep 6, 2024
Merged
Conversation
Contributor
|
Let me verify the PR with cisco platform. |
Collaborator
Author
|
Pushed another commit to limit the change to Mellanox only, and also run the test on multiple platforms. The change is also verified on a SN4700 testbed with Mellanox leaf fanout. |
Collaborator
Author
|
@nhe-NV Can you help review this change? |
Collaborator
|
@bingwang-ms PR conflicts with 202405 branch |
Collaborator
Author
|
Awaiting PR #14041 to be cherry-picked. |
This was referenced Sep 6, 2024
hdwhdw
pushed a commit
to hdwhdw/sonic-mgmt
that referenced
this pull request
Sep 20, 2024
* Stabilize PFC watchdog test * Limit the change to Mellanox
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
* Stabilize PFC watchdog test * Limit the change to Mellanox
vikshaw-Nokia
pushed a commit
to vikshaw-Nokia/sonic-mgmt
that referenced
this pull request
Oct 23, 2024
* Stabilize PFC watchdog test * Limit the change to Mellanox
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
This PR is to stabilize PFC watchdog test.
Changes include
This is because I didn't see improvement using multiple processes to send PFC pause frames when there is only 1 port to be paused. And the multi-processing caused test flakiness in
test_pfcwd_multi_portBefore this change, there was a hard-coded 5 seconds delay. But on some platform (e.g, Mellanox) more time is needed until PFC watchdog is triggered.
Type of change
Back port request
Approach
What is the motivation for this PR?
This PR is to stabilize PFC watchdog test.
How did you do it?
How did you verify/test it?
The change is verified on a Mellanox testbed. All test cases in
pfcwd/test_pfcwd_function.pyare consistently passing now.Any platform specific information?
No.
Supported testbed topology if it's a new test case?
Not a new test case.
Documentation