[action] [PR:13203] Ignore received packets that weren't sent during examine_flow#14324
Merged
mssonicbld merged 1 commit intosonic-net:202405from Sep 2, 2024
Merged
Conversation
…net#13203) What is the motivation for this PR? The platform_tests.test_advanced_reboot.test_fast_reboot test was failing due to received packets that weren't sent. How did you do it? How did you verify/test it? Modified the examine_flow function to run independently then tested the logic with a series of pcap files with various missing packets in the sequence. The cases included: 100 packets, happy path 100 packets, 0th packet receive missing 100 packets, 0th packet send missing 100 packets, 10th packet both missing, 11th packet both missing 100 packets, 10th packet both missing, 11th packet receive missing 100 packets, 10th packet both missing, 11th packet send missing 100 packets, 10th packet both missing 100 packets, 10th packet receive missing, 11th packet receive missing 100 packets, 10th packet receive missing, 11th packet send missing 100 packets, 10th packet receive missing 100 packets, 10th packet send missing, 11th packet receive missing 100 packets, 10th packet send missing, 11th packet send missing 100 packets, 10th packet send missing 100 packets, bunch of sad cases all in one: pkt-10 both missing pkt-15 send missing pkt-20 receive missing pkt-25 both missing, pkt-26 both missing pkt-30 both missing, pkt-31 send missing pkt-35 both missing, pkt-36 receive missing pkt-45 receive missing, pkt-46 receive missing pkt-55 receive missing, pkt-56 send missing pkt-65 send missing, pkt-66 send missing pkt-75 send missing, pkt-76 receive missing 100 packets, first 10 packets missing Any platform specific information?
8 tasks
Collaborator
Author
|
Original PR: #13203 |
Collaborator
Author
|
/azp run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to process received packets that weren't sent resulted in a KeyError exception in the examine_flow disruption calculation. This commit ignores them.
Description of PR
Summary:
Fixes # (issue)
Microsoft ADO: 27806353
Type of change
Back port request
Approach
What is the motivation for this PR?
The platform_tests.test_advanced_reboot.test_fast_reboot test was failing due to received packets that weren't sent.
How did you do it?
How did you verify/test it?
Modified the
examine_flowfunction to run independently then tested the logic with a series of pcap files with various missing packets in the sequence. The cases included:Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation