[action] [PR:14124] BGP [T2] - Update neighbor admin down only for specific asic under test#14315
Merged
mssonicbld merged 1 commit intosonic-net:202405from Sep 2, 2024
Merged
Conversation
…st (sonic-net#14124) Description of PR Summary: Fixes # (issue) This PR fixes issue on 'test_bgp_peer_shutdown.py', when the test runs on T2 multi-asic dut. Whole test operates on one of the asic but during bgp teardown session; while removing newly added neighbor config, test runs sonic-db-cli command on both asics of the dut, which creates a dummy neighbor entry on the other asic. Due to this, test fails with the following reason, with capture_bgp_packages_to_file(duthost, "any", bgp_pcap, n0.namespace): n0.teardown_session() if not wait_until( WAIT_TIMEOUT, 5, 20, lambda: is_neighbor_session_down(duthost, n0), ): > pytest.fail("Could not tear down bgp session") E Failed: Could not tear down bgp session Approach What is the motivation for this PR? Test creates a dummy bgp neighbor entry on the other asic, where the test is not operating. Due to this test fails. For example, dummy entry 20.0.0.1 on the other asic is shown below. show ip bgp sum IPv4 Unicast Summary (VRF default): BGP router identifier 8.0.0.2, local AS number 65100 vrf-id 0 BGP table version 4468 RIB entries 3245, using 710 KiB of memory Peers 6, using 4348 KiB of memory Peer groups 4, using 256 bytes of memory Neighbor V AS MsgRcvd MsgSent TblVer InQ OutQ Up/Down State/PfxRcd PfxSnt Desc 10.0.0.7 4 65200 29995 30093 0 0 0 1d00h57m 1057 1611 ARISTA04T3 10.0.0.11 4 65200 29994 30094 0 0 0 1d00h57m 1058 1611 ARISTA06T3 20.0.0.1 4 0 0 0 0 0 0 never Connect 0 N/A 3.3.3.0 4 65100 29964 29991 0 0 0 1d00h50m 2057 2119 ASIC0 3.3.3.42 4 65100 29882 29988 0 0 0 1d00h50m 133 2119 ixre-egl-board182-AS 3.3.3.44 4 65100 29912 29990 0 0 0 1d00h50m 134 2119 ixre-egl-board182-AS How did you do it? While removing new bgp neighbor config, make sure it is removed only for the specific asic under test. How did you verify/test it? Ran all the above-mentioned test case on a T2 multi-asic chassis and made sure test passed with expected behavior. Any platform specific information? Supported testbed topology if it's a new test case? Documentation image co-authorized by: jianquanye@microsoft.com
8 tasks
Collaborator
Author
|
Original PR: #14124 |
Collaborator
Author
|
/azp run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
For example, dummy entry 20.0.0.1 on the other asic is shown below.
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation