Enhancement of test_sensors.py to address several issues

[mhen1]

Description of PR

Summary:
Fixes # (issue)
Enhancement of test_sensors.py to address several issues:

1. Updated PSU mapping of msn4600-r0 platform.
2. Updated test to support both Forward (PSF) and Reversed (PSR) versions of each PSU Model.
3. Added support to PSU Model MTEF-AC-G.

Type of change

• Bug fix
• [] Testbed and Framework(new/improvement)
• Test case(new/improvement)

Back port request

• 202012
• 202205
• 202305
• 202311
• 202405

Approach

What is the motivation for this PR?

Address several issues with the sensor test case.

How did you do it?

Updated the Dynamic PSU mapping process to address the issues.

How did you verify/test it?

Run test_sensors.py on several Systems (each of the PSU Models listed in psu_data.yaml).

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

[mssonicbld]

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing tests/platform_tests/sensors_utils/psu_sensor_utils.py

check yaml...............................................................Passed
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/platform_tests/test_sensors.py:56:121: E501 line too long (138 > 120 characters)

flake8...............................................(no files to check)Skipped
check conditional mark sort..............................................Passed

To run the pre-commit checks locally, you can follow below steps:

1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
   the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
   docker container.
2. Ensure that the pre-commit package is installed:

sudo pip install pre-commit

3. Go to repository root folder
4. Install the pre-commit hooks:

pre-commit install

5. Use pre-commit to check staged file:

pre-commit

6. Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

[mssonicbld]

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing tests/platform_tests/sensors_utils/psu_sensor_utils.py

check yaml...............................................................Passed
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/platform_tests/test_sensors.py:56:121: E501 line too long (138 > 120 characters)

flake8...............................................(no files to check)Skipped
check conditional mark sort..............................................Passed

To run the pre-commit checks locally, you can follow below steps:

1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
   the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
   docker container.
2. Ensure that the pre-commit package is installed:

sudo pip install pre-commit

3. Go to repository root folder
4. Install the pre-commit hooks:

pre-commit install

5. Use pre-commit to check staged file:

pre-commit

6. Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

[wsycqyz]

Do we need this PR in 202311 or 202405 branch?

[mhen1]

Hey, The PR is needed in 202311/202405, but please wait with merging it as the issues mentioned might not be resolved yet, I’ll let you know once they are. Thanks, Mor Hen From: ShiyanWangMS ***@***.***> Sent: Tuesday, 20 August 2024 3:57 To: sonic-net/sonic-mgmt ***@***.***> Cc: Mor Hen ***@***.***>; Author ***@***.***> Subject: Re: [sonic-net/sonic-mgmt] Enhancement of test_sensors.py to address several issues (PR #14154) Do we need this PR in 202311 or 202405 branch? — Reply to this email directly, view it on GitHub<#14154 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BFFHNL6KMMEGMWFQOASUNZDZSKH43AVCNFSM6AAAAABMWIEQX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJXG43DMMBRGA>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[bingwang-ms]

I confirmed this PR will fix the test_sensor failure on SN4600. But the failure on SN2700A1 is not fixed. Need some update.

[mhen1]

I confirmed this PR will fix the test_sensor failure on SN4600. But the failure on SN2700A1 is not fixed. Need some update.

Hey, I believe the following PR to sonic-buildimage should resolve the issue - sonic-net/sonic-buildimage#19515
Please verify it does and if so, This PR is ready from my part (and needs to be backported to 202311/202405 as well).

[bingwang-ms]

LGTM.

[mssonicbld]

Cherry-pick PR to 202405: #14488

[mssonicbld]

Cherry-pick PR to 202311: #14489