Adding a new test for FIB in pytest#1413
Merged
lguohan merged 1 commit intosonic-net:masterfrom Mar 5, 2020
Merged
Conversation
…e fib test. Signed-off-by: Arvindsrinivasan Lakshminarasimhan <[email protected]>
prsunny
approved these changes
Feb 28, 2020
Contributor
|
@arlakshm , as i understand, this is converting the existing ansible test to pytest right? The title mentions as adding new test.. Just clarifying |
Contributor
Author
|
@prsunny, This is new test in pytest, so I marked it as new test. |
yxieca
reviewed
Mar 2, 2020
| def test_fib(ansible_adhoc, testbed, duthost, ptfhost,ipv4, ipv6, mtu): | ||
|
|
||
| t1_topologies = ['t1', 't1-lag', 't1-64-lag', 't1-64-lag-clet'] | ||
| t0_topologies = ['t0', 't0-52', 't0-56', 't0-64', 't0-64-32', 't0-116'] |
Collaborator
There was a problem hiding this comment.
I am wondering if you could make this more generic?
Having these 2 above list meaning that if we define a new topology in the future. This test code needs to be changed too. Previously we only have to change the testcase.yml.
Contributor
There was a problem hiding this comment.
good concern, this needs to work together with the new fib fixture. suggest to address in a separate pr.
lguohan
reviewed
Mar 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a test for FIB in pytest.
Signed-off-by: Arvindsrinivasan Lakshminarasimhan [email protected]
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
How did you do it?
Convert the ansible fib test to py test
How did you verify/test it?
Verify on the test run on existing platform
Any platform specific information?
None
Supported testbed topology if it's a new test case?
This test is support in T1 and T0 topologies
Documentation